Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contactsmenu overflow #10447

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Fix contactsmenu overflow #10447

merged 1 commit into from
Jul 30, 2018

Conversation

skjnldsv
Copy link
Member

Fix #10442

@nextcloud/designers @wallenium

@skjnldsv
Fix contactsmenu overflow
fa54668 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews 14-beta-feedback labels Jul 30, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Jul 30, 2018
@skjnldsv skjnldsv self-assigned this Jul 30, 2018
danxuliu
danxuliu approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzer rullzer merged commit d29e86b into master Jul 30, 2018
@rullzer rullzer deleted the contactsmenu-height-fix branch July 30, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @rullzer @danxuliu