Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings design polishing #10480

Merged
merged 9 commits into from
Aug 2, 2018
Merged

Settings design polishing #10480

merged 9 commits into from
Aug 2, 2018

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 1, 2018 •
edited
Loading

From #10094

  • User management: Table headers should be lighter font color than the rest of the text
  • External storages: Could use a settings-hint text like "You can mount different storage services as folders into your Nextcloud." Global credentials also needs explanation
  • External storages: Settings menu should use 3-dot-icon, and delete action should go in there too (as last entry)
  • Personal info: Vertical whitespace is a bit much. If it's cause of the region format, put time and date on one row.
  • Merge Server-side encryption into "Security" section?
  • Groupware: "Calendar settings" instead of "CalDAV server", and more whitespace between settings.
  • Workflow: Create a new tag input field should also create the tag on pressing enter

@juliusknorr
Move locale preview to two lines to reduce grid height
f499f1b 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Make user management heading font size lighter
8abec69 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Rename CalDAV to Calendar settings
9b46814 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
files_external: Move delete option to 3-dots menu
635575f 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
files_external: Add description to settings
10de5f2 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Move encryption settings to security
03971d3 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
systemtags: Submit input on enter
b46b7d7 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Aug 1, 2018
@juliusknorr juliusknorr added this to the Nextcloud 14 milestone Aug 1, 2018
skjnldsv
skjnldsv approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jancborchardt jancborchardt mentioned this pull request Aug 1, 2018
Closed
31 tasks
rullzer
rullzer previously requested changes Aug 1, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests fail

@juliusknorr
Fix encryption admin section tests
0dd519c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

@rullzer Unit tests fixed.

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

LGTM! 🛥️

@rullzer
Copy link
Member

rullzer commented Aug 2, 2018

@juliushaertl are you sure: https://drone.nextcloud.com/nextcloud/server/9390/251

@juliusknorr
Copy link
Member Author

@rullzer Sorry, missed that when scrolling though the drone report, I've just recognized the files-acceptance failure. 🙈 will fix

@juliusknorr
files_external: Fix jsunit tests
84f99db 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer rullzer merged commit 01298cf into master Aug 2, 2018
@rullzer rullzer deleted the bugfix/10420/settings branch August 2, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @skjnldsv @rullzer