Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the info available if the avatar was uploaded or generated #10481

Merged

Conversation

nickvergessen
Copy link
Member

Allows Talk to know if the avatar is the generated character of the name, or a custom image:
nextcloud/talk-android#223 (comment)

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added enhancement 3. to review Waiting for reviews labels Aug 1, 2018
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Aug 1, 2018
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 1, 2018
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests not happy

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

pushed

@rullzer rullzer merged commit fae7e51 into master Aug 1, 2018
@rullzer rullzer deleted the feature/noid/make-info-available-if-the-avatar-was-uploaded branch August 1, 2018 20:54
@MorrisJobke MorrisJobke mentioned this pull request Aug 1, 2018
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants