Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix design of update error page #10485

Merged
merged 7 commits into from
Aug 6, 2018
Merged

Fix design of update error page #10485

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81dc12a
Fix triangle on update page
jancborchardt Aug 1, 2018
d64a9f3
Fix text overflow on update page
jancborchardt Aug 1, 2018
ede469a
Inline error svg icon because there is no SCSS on guest page
jancborchardt Aug 1, 2018
4574698
Fix double container on 'Possible CSRF attack' page
jancborchardt Aug 1, 2018
2fb6799
Use images instead of inline SVG and unicode
jancborchardt Aug 3, 2018
49cbd8c
Add margin below detailed logs
jancborchardt Aug 3, 2018
6d7bf81
Fix HTML on update error page
jancborchardt Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/css/guest.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ form #selectDbType label.ui-state-active {
background-color: rgba(0,0,0,.3);
color: #fff;
text-align: left;
word-wrap: break-word;
border-radius: 3px;
cursor: default;
-moz-user-select: text;
Expand Down Expand Up @@ -630,6 +631,9 @@ p.info {
margin: 10px;
background-size: 32px;
}
#update-progress-icon.icon-error-white {
background-image: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewbox="0 0 16 16" width="16" height="16"><path d="M5.516 2L2 5.516v4.968L5.516 14h4.968L14 10.484V5.516L10.484 2H5.516zM7 4h2v5H7V4zm0 6h2v2H7v-2z" fill="%23fff"/></svg>');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not relative path url?

Copy link
Member

@juliusknorr juliusknorr Aug 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restored the white icon file in #10459 so you can use that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I will restore the white error icon too.

}

/* Icons */
.icon-info-white {
Expand Down
2 changes: 1 addition & 1 deletion core/js/update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
$(window).off('beforeunload.inprogress');
self.setErrorMessage(message);
message = t('core', 'Please reload the page.');
$('<span>').addClass('error').append('<a href=".">'+message+'</a><br />').appendTo($el);
$('<p>').append('<a href=".">'+message+'</a>').appendTo($el);
updateEventSource.close();
});
updateEventSource.listen('failure', function(message) {
Expand Down
2 changes: 1 addition & 1 deletion core/templates/update.admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<p id="update-progress-message-error" class="hidden"></p>
<ul id="update-progress-message-warnings" class="hidden"></ul>
<p id="update-progress-message"></p>
<a class="update-show-detailed"><?php p($l->t( 'Detailed logs' )); ?> <img src="<?php print_unescaped(image_path('', 'actions/caret.svg')); ?>" /></a>
<a class="update-show-detailed"><?php p($l->t( 'Detailed logs' )); ?> ⏷</a>
<div id="update-progress-detailed" class="hidden"></div>
</div>
</div>