Fix app management not providing updates for apps which got disabled #10508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
… not installed) Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
3. to review
rullzer
reviewed
Aug 2, 2018
| @@ -389,7 +389,7 @@ public function isUpdateAvailable($appId) { | |||
| if($app['id'] === $appId) { | |||
| $currentVersion = OC_App::getAppVersion($appId); | |||
| $newestVersion = $app['releases'][0]['version']; | |||
| if (version_compare($newestVersion, $currentVersion, '>')) { | |||
| if ($currentVersion !== '0' && version_compare($newestVersion, $currentVersion, '>')) { | |||
There was a problem hiding this comment.
Ah I should read the commit messages
There was a problem hiding this comment.
server/lib/private/App/AppManager.php
Lines 394 to 397 in f30c14a
When the app is not "available". so basically when it's only in the response of the appstore but can not be found locally
juliusknorr
approved these changes
Aug 2, 2018
juliusknorr
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.