Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min height 100% on content-wrapper #10519

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Min height 100% on content-wrapper #10519

merged 1 commit into from
Aug 3, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 3, 2018

Make sure loaders or stuff are always taking full height on content-details as well :)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews 14-beta-feedback labels Aug 3, 2018
@skjnldsv skjnldsv self-assigned this Aug 3, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Aug 3, 2018
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes my issue 👍

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 3, 2018
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 3, 2018

Failures unrelated. Want to restart the build @rullzer ?

@rullzer
Copy link
Member

rullzer commented Aug 3, 2018

@ChristophWurst
Copy link
Member

Failures look unrelated to me too

https://drone.nextcloud.com/nextcloud/server/9422/119

@rullzer rullzer merged commit 755f13e into master Aug 3, 2018
@rullzer rullzer deleted the min-height-wrapper branch August 3, 2018 12:05
@rullzer rullzer mentioned this pull request Aug 6, 2018
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants