-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test for table schedulingobjects and fixing postgres LOB #10523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
LGTM, not tested. |
@janLo could you signoff your commit, so that the checker test passes? |
Are you sure, that I should sign off the work from another person? Shouldn't be the original commit be signed in the first place? |
@janLo you don't have to be the copyright owner to sign the commit. By signing you just declare:
see https://github.com/nextcloud/server/blob/master/contribute/developer-certificate-of-origin So if you copied the fix from the public repository of ownCloud and checked that it is licensed under a compatible license then it is absolutely OK to sign it. Actually that's the purpose, you basically say that you checked "to the best of my knowledge" that you can contribute the code to Nextcloud under the license used by Nextcloud. |
(cherry picked from commit afd4ebf0404e8bcd7cba0bec2dce177e97632f8a) Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
done. |
backport in #10552 |
This is a fix for #8825. It was fixed in Owncloud in owncloud/core@afd4ebf So this is just a cherry-pick of that fix.