Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for table schedulingobjects and fixing postgres LOB #10523

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

janLo
Copy link

@janLo janLo commented Aug 3, 2018

This is a fix for #8825. It was fixed in Owncloud in owncloud/core@afd4ebf So this is just a cherry-pick of that fix.

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@enoch85
Copy link
Member

enoch85 commented Aug 3, 2018

LGTM, not tested.

@blizzz
Copy link
Member

blizzz commented Aug 6, 2018

@janLo could you signoff your commit, so that the checker test passes?

@janLo
Copy link
Author

janLo commented Aug 6, 2018

Are you sure, that I should sign off the work from another person? Shouldn't be the original commit be signed in the first place?

@schiessle
Copy link
Member

@janLo you don't have to be the copyright owner to sign the commit. By signing you just declare:

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

see https://github.com/nextcloud/server/blob/master/contribute/developer-certificate-of-origin

So if you copied the fix from the public repository of ownCloud and checked that it is licensed under a compatible license then it is absolutely OK to sign it. Actually that's the purpose, you basically say that you checked "to the best of my knowledge" that you can contribute the code to Nextcloud under the license used by Nextcloud.

(cherry picked from commit afd4ebf0404e8bcd7cba0bec2dce177e97632f8a)

Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
@janLo
Copy link
Author

janLo commented Aug 6, 2018

done.

@blizzz
Copy link
Member

blizzz commented Aug 6, 2018

backport in #10552

@rullzer rullzer mentioned this pull request Aug 8, 2018
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants