-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed notifications position #10525
Fixed notifications position #10525
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
How do I test this? |
@ChristophWurst find a page who scrolls, create a temp notification, scroll and see the notification fly up as you scroll |
Thanks! Can verify the patch working. Isn't this fixing the visual bug I was asking you about a few days ago and you said there was no bug? 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 🙌
Does not work for me with multi line notifications or multiple ones. Just copied the style using dev-tools and added some notifications with |
@danopz the notification always have been on top of the header. This fixes the scrolling issue on the notification. |
Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com