Adds a setup and cli check for the recommended memory limit #10539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
rullzer,
nickvergessen,
MorrisJobke and
juliusknorr
juliusknorr
added
enhancement
3. to review
lib/private/Server.php
Outdated
| @@ -273,6 +273,10 @@ public function __construct($webRoot, \OC\Config $config) { | |||
| }); | |||
| $this->registerAlias('SystemTagManager', \OCP\SystemTag\ISystemTagManager::class); | |||
|
|
|||
| $this->registerService(MemoryInfo::class, function() { | |||
There was a problem hiding this comment.
this should not be required but work automatically
|
Lets also try to get this into 14. |
weeman1337
force-pushed
the
feature-8642-memory-check
branch
2 times, most recently
from
47f9fdb to
71a3ae5
Compare
rullzer
force-pushed
the
feature-8642-memory-check
branch
from
71a3ae5 to
d4f26eb
Compare
|
I rebased. Squased the last commit in the first one. And bumped the autoloader. |
rullzer
force-pushed
the
feature-8642-memory-check
branch
from
d4f26eb to
6211577
Compare
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
…w the recommended value Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
skjnldsv
force-pushed
the
feature-8642-memory-check
branch
from
6211577 to
ce1e213
Compare
|
Rebased and cleaned up. |
blizzz
reviewed
Aug 20, 2018
| @@ -0,0 +1,60 @@ | |||
| <?php | |||
There was a problem hiding this comment.
declare strict types, please, and also the license header as found on other PHP files
There was a problem hiding this comment.
Thanks for the review. I added the license texts and PHP strict mode.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
skjnldsv
approved these changes
Aug 21, 2018
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
approved these changes
Aug 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
MemoryInfoclass that handles the memory limit query. I didn't put it into thepublicnamespace.Closes #8642