Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the apps list layout #10561

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Fixes the apps list layout #10561

merged 2 commits into from
Aug 8, 2018

Conversation

weeman1337
Copy link
Member

  • Adds a (missing) container element for the search result apps list
  • Introduces the apps-list class
  • Tweaks the search results headline to take the remaining width

Closes #10476

skjnldsv
skjnldsv approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :)

@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 7, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Aug 7, 2018
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 7, 2018
@juliusknorr
Copy link
Member

Nice, thanks a lot for the fix. 👍

@weeman1337 @juliusknorr
Fixes the apps list layout
d163614 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337 @juliusknorr
Updates the built files
978fc50 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@juliusknorr juliusknorr force-pushed the fix/10476/applist-layout branch from f58dedf to 978fc50 Compare August 7, 2018 16:02
@juliusknorr
Copy link
Member

Pushed to retrigger CI.

@skjnldsv skjnldsv merged commit e595cad into master Aug 8, 2018
@skjnldsv skjnldsv deleted the fix/10476/applist-layout branch August 8, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@weeman1337 @juliusknorr @skjnldsv