-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow external actions to users list #10592
Conversation
17d7080
to
9a4a956
Compare
That's great, yet I am having difficulties to get the user id from an external app. Suggestions? |
@blizzz |
@skjnldsv that does the trick! thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my PoV, and satisfies the needs for impersonate
While ok from my point of view. I'd like @juliushaertl to have a look as his javascript fu is superior to mine ;) |
@blizzz Are there any cases where those actions should not be added, like for the current user? Because right now there is no way to exclude certain entries from adding the additional popovermenu entry. Otherwise 👍 |
Rebase needed |
@juliushaertl yeah, for the current user it does not make sense to add it. But that one does not have the menu anyway. |
@skjnldsv could ya rebase? |
+ Created fix Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
dcc3db4
to
b9a24bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then lets do this 🐘
@juliushaertl thoughts?
Fix #10571