Do not use file as template parameter #10614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Aug 9, 2018
| @@ -249,7 +249,7 @@ public function afterException($controller, $methodName, \Exception $exception): | |||
| $url = $this->urlGenerator->linkToRoute('core.login.showLoginForm', $params); | |||
| $response = new RedirectResponse($url); | |||
| } else { | |||
| $response = new TemplateResponse('core', '403', ['file' => $exception->getMessage()], 'guest'); | |||
| $response = new TemplateResponse('core', '403', ['message' => $exception->getMessage()], 'guest'); | |||
There was a problem hiding this comment.
maybe trying to assign predefined parameters should throw an error
And only work via a ->forceAssign method?
Using file will overwrite the $file parameter in the template base. Leading to trying to include a file that is the exception message. Which will of course fail. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
bugfix/noid/fix_including_invalid_file
branch
from
2266de2 to
8c1e75e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using file will overwrite the $file parameter in the template base.
Leading to trying to include a file that is the exception message. Which
will of course fail.
See: https://sentry.rullzer.com/share/issue/5b5ae2d0777e4ac7915de8c846c21098/