Header fixes and public note #10838
Merged
Header fixes and public note #10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
bug
enhancement
design
skjnldsv
requested review from
rullzer,
MorrisJobke,
jancborchardt and
juliusknorr
MorrisJobke
approved these changes
Aug 24, 2018
rullzer
approved these changes
Aug 24, 2018
|
@skjnldsv Please check out the failing acceptance and jsunit tests |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
…tcloud/server into header-fixes-and-public-note Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
header-fixes-and-public-note
branch
from
3ffac6b to
03b112c
Compare
skjnldsv
added
4. to release
|
@skjnldsv JS Unit still fails 😕 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
rullzer
removed
the
4. to release
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix headers apps calculation
Added breakpoints on mobile for the public share
Fixed order of shares list (public on top)
Fix header menu mobile break