Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates logo scss to regard default values #11048

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Updates logo scss to regard default values #11048

merged 1 commit into from
Sep 4, 2018

Conversation

juliusknorr
Copy link
Member

Cherry picked 84fa208 from #10963 so we have this regression fixed for the 14 release. The other commit is more polishing, so we can still backport it later.

Steps to reproduce:

  • Upload a custom logo to the theming app

Before:

  • Logo missing

After:

  • Logo is shown properly

@weeman1337 @juliusknorr
Updates logo scss to regard default values
a74629d 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@juliusknorr juliusknorr added this to the Nextcloud 14 milestone Sep 4, 2018
@juliusknorr juliusknorr mentioned this pull request Sep 4, 2018
Merged
@juliusknorr
Copy link
Member Author

CI failure unrelated, probably due to app store timeout:

  Scenario: View app details for app store apps       # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:74
    Given I act as Jane                               # ActorContext::iActAs()
    And I am logged in as the admin                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                    # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                    # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2018
@juliusknorr juliusknorr merged commit 8feadb8 into master Sep 4, 2018
@rullzer
Copy link
Member

rullzer commented Sep 4, 2018

@juliushaertl hehe so you did this against master and not stable14 it seems

@juliusknorr
Copy link
Member Author

juliusknorr commented Sep 5, 2018 •
edited
Loading

Ah damn 🙈 Thanks for noticing.

@juliusknorr juliusknorr modified the milestones: Nextcloud 14, Nextcloud 15 Sep 5, 2018
@juliusknorr juliusknorr changed the title [stable14] Updates logo scss to regard default values Updates logo scss to regard default values Sep 5, 2018
@MorrisJobke
Copy link
Member

Ah damn 🙈 Thanks for noticing.

What about the stable14 version of this?

@MorrisJobke MorrisJobke deleted the stable14-10963 branch October 1, 2018 09:04
@juliusknorr
Copy link
Member Author

Was merged in #11052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: theming regression
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @rullzer @MorrisJobke @skjnldsv @weeman1337