Fix user and group listing with users that have an integer user id #11181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
nickvergessen
force-pushed
the
bugfix/11178/user-list-broken-with-integer-only-users
branch
from
f3fba2f to
47d02c6
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/11178/user-list-broken-with-integer-only-users
branch
from
47d02c6 to
f0d4855
Compare
blizzz
approved these changes
Sep 12, 2018
|
I could swear i saw it working, but the code changes make total sense. Subsequently (separate PR) some tests would be nice to not fall into this trap again. |
blizzz
deleted the
bugfix/11178/user-list-broken-with-integer-only-users
branch
|
@nickvergessen can you do the backport, pls? |
Yeah same here, we fixed it a couple of times already.... |
|
Backport in #11186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11178