-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate the mention-notification with the actual message #12009
Populate the mention-notification with the actual message #12009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Quick smoke tests looks awesome
Signed-off-by: Joas Schilling <coding@schilljs.com>
1d35217
to
d295ff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not include the whole message initially to avoid leaking content wherever it may show up. It seems to be the state of the art across apps though, to display it immediately.
In itself it looks good. However, the notifications app itself does not seem to pull notifications (git master), I never see anything… thus, cannot really smoke test. The prepare()
method is not being entered either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, the notifications app itself does not seem to pull notifications (git master), I never see anything… thus, cannot really smoke test. The prepare() method is not being entered either. Another make build-js was missing… works!
@blizzz Maybe a bit to early, unit tests are failing on master: |
damn, scrolled to far and waived it off as unrelated noise :( |
Let me have a quick look about adjusting those tests, as they don't seem to be fundamentally broken |
take a few minutes more, I add a reverting PR. Sorry for the mess. |
@nickvergessen can you reopen with adjusted tests, please? |
Write a comment where you mention a user on a shared file.
The notification so far only says you where mentioned.
Now it includes the text of the comment (as plain text).
With nextcloud/notifications#190 it will also be parsed and the mentions should be clickable (if there where more than your own).