Cleanup some unused sharing methods from the old sharing code #12200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
ChristophWurst,
schiessle and
skjnldsv
rullzer
reviewed
Nov 2, 2018
| @@ -65,7 +65,7 @@ public function getForm() { | |||
| 'allowResharing' => $this->config->getAppValue('core', 'shareapi_allow_resharing', 'yes'), | |||
| 'allowShareDialogUserEnumeration' => $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes'), | |||
| 'enforceLinkPassword' => Util::isPublicLinkPasswordRequired(), | |||
| 'onlyShareWithGroupMembers' => Share::shareWithGroupMembersOnly(), | |||
| 'onlyShareWithGroupMembers' => $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'no') == 'yes', | |||
There was a problem hiding this comment.
server/lib/public/Share/IManager.php
Line 347 in b23032e
MorrisJobke
force-pushed
the
tech-debt/noid/cleanup-legacy-sharing
branch
from
76ecea9 to
d6bdfe6
Compare
rullzer
approved these changes
Nov 2, 2018
|
I know unit tests are failing ... looking into it |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
tech-debt/noid/cleanup-legacy-sharing
branch
from
d6bdfe6 to
248d953
Compare
|
CI failure is due to an unrelated trash bin problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in my stashes ;)