Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14] Disabled ldap fix #12331

Merged
merged 2 commits into from
Nov 7, 2018
Merged

[14] Disabled ldap fix #12331

merged 2 commits into from
Nov 7, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 7, 2018

Backport of #12306

skjnldsv and others added 2 commits November 7, 2018 13:19
@skjnldsv @rullzer
Show disabled even if empty if ldap enabled
df841cc 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer
Build settings
21c9146 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Nov 7, 2018
@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Nov 7, 2018
MorrisJobke
MorrisJobke approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit 1a079fd into stable14 Nov 7, 2018
@MorrisJobke MorrisJobke deleted the backport/12306/stable14 branch November 7, 2018 15:19
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
Merged
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 14.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @skjnldsv