-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix count on string #12650
Fix count on string #12650
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
apps/user_ldap/lib/Access.php
Outdated
* @param string|string[]|null $attr | ||
* @return bool | ||
*/ | ||
private function manyAttributes($attr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return type can be set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, thx!
@rullzer mind a re-review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍
/backport to stable15 |
/backport to stable14 |
backport to stable14 in #12684 |
backport to stable14 in #12683 |
@rullzer 😕 |
Should be fixed by nextcloud/backportbot#12 |
Fix #12614