Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count on string #12650

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Fix count on string #12650

merged 2 commits into from
Nov 27, 2018

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Nov 24, 2018

Fix #12614

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* @param string|string[]|null $attr
* @return bool
*/
private function manyAttributes($attr) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type can be set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

🙈 🙉

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thx!

@blizzz
Copy link
Member

blizzz commented Nov 27, 2018

@rullzer mind a re-review?

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit 95857a8 into master Nov 27, 2018
@MorrisJobke MorrisJobke deleted the bugfix/12614/count-on-string branch November 27, 2018 13:14
@MorrisJobke
Copy link
Member

/backport to stable15

@MorrisJobke
Copy link
Member

/backport to stable14

@backportbot-nextcloud
Copy link

backport to stable14 in #12684

@backportbot-nextcloud
Copy link

backport to stable14 in #12683

@kesselb
Copy link
Contributor Author

kesselb commented Nov 27, 2018

@rullzer 😕

@MorrisJobke
Copy link
Member

@rullzer 😕

Should be fixed by nextcloud/backportbot#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants