Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify headers menu design, fix click area #12785

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 3, 2018

@skjnldsv skjnldsv added bug enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Dec 3, 2018
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Dec 3, 2018
@skjnldsv skjnldsv self-assigned this Dec 3, 2018
@skjnldsv skjnldsv force-pushed the head-menu-half-height-fix branch from e33dd2d to d91d681 Compare December 3, 2018 08:52
@jancborchardt
Copy link
Member

Oooooh großartig Herr @skjnldsv, thanks for picking that up! Will get to reviewing right away 🥇

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In both Firefox and Chrome, both for mouse and keyboard interaction, I see this for the "More apps" menu:
Opens and then immediately closes again, is only visible for a split second (is much quicker really, the gif is not really proper):
menu does not open

@jancborchardt
Copy link
Member

Other than my review about the directly closing "More apps" menu it looks good!

(My #9752 is/was not only about headers btw, but also about other menus like the "+ New" menu in Files as well as the 3-dot menu of every file which e.g. don’t have proper sizes and also no proper hover/focus feedback. :)

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 4, 2018
@skjnldsv skjnldsv force-pushed the head-menu-half-height-fix branch from d91d681 to d78b252 Compare December 19, 2018 15:53
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 19, 2018
@jancborchardt
Copy link
Member

Can more @nextcloud/designers test too? :)

(My #9752 is/was not only about headers btw, but also about other menus like the "+ New" menu in Files as well as the 3-dot menu of every file which e.g. don’t have proper sizes and also no proper hover/focus feedback. :)

@skjnldsv this part would then be separate? :)

@skjnldsv
Copy link
Member Author

@skjnldsv this part would then be separate? :)

You mean actions inside the popovermenu?

@jancborchardt
Copy link
Member

@skjnldsv yes. Or do you want to directly do it in this pull request too? Because the Closes #9752 is not entirely correct as I mentioned. ;)

@skjnldsv
Copy link
Member Author

I'll add this here :)

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 8, 2019
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the head-menu-half-height-fix branch from d78b252 to ecede42 Compare January 29, 2019 07:43
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 29, 2019

All done @nextcloud/designers
capture d ecran_2019-01-29_08-36-00 capture d ecran_2019-01-29_08-42-26
capture d ecran_2019-01-29_08-42-41

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 29, 2019
@MorrisJobke
Copy link
Member

Still looks like this (Safari and Chrome)

bildschirmfoto 2019-01-29 um 12 17 58

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 30, 2019

Done @MorrisJobke
@nextcloud/designers

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do this 🐘

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2019
@MorrisJobke MorrisJobke merged commit 681437d into master Jan 30, 2019
@MorrisJobke MorrisJobke deleted the head-menu-half-height-fix branch January 30, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants