-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify headers menu design, fix click area #12785
Conversation
e33dd2d
to
d91d681
Compare
Oooooh großartig Herr @skjnldsv, thanks for picking that up! Will get to reviewing right away 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my review about the directly closing "More apps" menu it looks good! (My #9752 is/was not only about headers btw, but also about other menus like the "+ New" menu in Files as well as the 3-dot menu of every file which e.g. don’t have proper sizes and also no proper hover/focus feedback. :) |
d91d681
to
d78b252
Compare
Can more @nextcloud/designers test too? :)
@skjnldsv this part would then be separate? :) |
You mean actions inside the popovermenu? |
@skjnldsv yes. Or do you want to directly do it in this pull request too? Because the |
I'll add this here :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
d78b252
to
ecede42
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Done @MorrisJobke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do this 🐘
Closes Menu entry clickability #9752
Fix User-menu-dropdown: Full row should be clickable #12550
Fix 14.0.x: Drop-down settings menu does not scale to accommodate additional entries #11791
Fix Usability of 3-dot "More Apps" Menu with many Apps #12565