Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Emit write update only once on touch #12869

Merged
merged 1 commit into from
Dec 6, 2018
Merged

[stable14] Emit write update only once on touch #12869

merged 1 commit into from
Dec 6, 2018

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #12857

@rullzer
Emit write update only once on touch
bdd974d 
When a touch is done (i.e. when creating a new file in the node API)
The hooks contain 'write' and 'touch' (and the operation is touch as
well). This would cause a double write update. Which doesn't make sense.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 5, 2018
Merged
@MorrisJobke MorrisJobke added bug 3. to review Waiting for reviews labels Dec 5, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14.0.5 milestone Dec 5, 2018
MorrisJobke
MorrisJobke approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2018
@rullzer rullzer merged commit 2d6cfdc into stable14 Dec 6, 2018
@rullzer rullzer deleted the backport/12857/stable14 branch December 6, 2018 07:30
@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 14.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @ChristophWurst @rullzer