Correctly remove admin sections and settings #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz and @LukasReschke to be potential reviewers |
| @@ -105,10 +105,10 @@ public function onAppDisabled($appId) { | |||
| $appInfo = \OC_App::getAppInfo($appId); // hello static legacy | |||
|
|
|||
| if(isset($appInfo['settings'][IManager::KEY_ADMIN_SECTION])) { | |||
| $this->remove(self::TABLE_ADMIN_SECTIONS, $appInfo['settings'][IManager::KEY_ADMIN_SECTION]); | |||
| $this->remove(self::TABLE_ADMIN_SECTIONS, trim($appInfo['settings'][IManager::KEY_ADMIN_SECTION], '\\')); | |||
There was a problem hiding this comment.
all other methods use get_class which has no leading slash: https://3v4l.org/rquje
|
LGTM |
1 similar comment
|
LGTM |
|
@nickvergessen could you prepare the backports? |
|
Yes, backport in #1305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
See https://help.nextcloud.com/t/usage-report-0-1-5-error-in-logs-if-we-disable-this-app/2963
Expected
nothing
Actually
Each page refresh logs a new QueryException
We can't really create an update step for this, because on update apps are disabled and therefor we can't check, if the class would exist. So manual clean up is required.