improve lookup server behaviour #13401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't try to connect to the lookup server if the lookup server was disabled by the admin or an empty lookup server URL was given Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
MorrisJobke
reviewed
Jan 7, 2019
rullzer
reviewed
Jan 7, 2019
|
@schiessle ping |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
|
@rullzer from my pov this is ready to go in after my last commits from yesterday |
|
CI failure unrelated |
|
Should we backport this? I guess it would make sense. |
|
/backport to stable15 |
|
backport to stable15 in #14696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to connect to the lookup server if the lookup server was disabled
by the admin or an empty lookup server URL was given
fix #13396
Additionally we should consider to add a background job which clean existing data from the lookup sever once the admin disabled it, see #13396 (comment)