Remove warning in case of external storage error #13891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
rullzer,
nickvergessen,
MorrisJobke,
ChristophWurst and
blizzz
juliusknorr
approved these changes
Jan 30, 2019
skjnldsv
added
4. to release
|
/backport to stable15 |
|
backport to stable15 in #13920 |
This was referenced Feb 7, 2019
|
what was the reason for the removal? |
There was a banner at the top that was not dismissible and caused a lot of confusion, because already the entry shows the "this mount is not available" information. Thus we decided to remove the notification banner. |
|
makes sense, ideally in future this is part of the PR text or better the commit message. In a couple months nobody knows anymore :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.