Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sensitive SMB arguments from exception log #14644

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Remove sensitive SMB arguments from exception log #14644

merged 1 commit into from
Mar 13, 2019

Conversation

MorrisJobke
Copy link
Member

Found while checking some logs.

Those are the logs:

Show full log 
{
    "reqId": "....",
    "level": 0,
    "time": "...",
    "remoteAddr": "...",
    "user": "MyUser",
    "app": "no app in context",
    "method": "PUT",
    "url": "/apps/files_external/userstorages/123",
    "message": {
        "Exception": "Icewind\\SMB\\Exception\\InvalidArgumentException",
        "Message": "Invalid request for / (InvalidArgumentException)",
        "Code": 22,
        "Trace": [
            {
                "file": "/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php",
                "line": 61,
                "function": "fromMap",
                "class": "Icewind\\SMB\\Exception\\Exception",
                "type": "::",
                "args": [
                    {
                        "1": "Icewind\\SMB\\Exception\\ForbiddenException",
                        "2": "Icewind\\SMB\\Exception\\NotFoundException",
                        "13": "Icewind\\SMB\\Exception\\ForbiddenException",
                        "16": "Icewind\\SMB\\Exception\\FileInUseException",
                        "17": "Icewind\\SMB\\Exception\\AlreadyExistsException",
                        "20": "Icewind\\SMB\\Exception\\InvalidTypeException",
                        "21": "Icewind\\SMB\\Exception\\InvalidTypeException",
                        "22": "Icewind\\SMB\\Exception\\InvalidArgumentException",
                        "28": "Icewind\\SMB\\Exception\\OutOfSpaceException",
                        "39": "Icewind\\SMB\\Exception\\NotEmptyException",
                        "110": "Icewind\\SMB\\Exception\\TimedOutException",
                        "111": "Icewind\\SMB\\Exception\\ConnectionRefusedException",
                        "112": "Icewind\\SMB\\Exception\\HostDownException",
                        "113": "Icewind\\SMB\\Exception\\NoRouteToHostException"
                    },
                    22,
                    "/"
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php",
                "line": 73,
                "function": "handleError",
                "class": "Icewind\\SMB\\Native\\NativeState",
                "type": "->",
                "args": [
                    "/"
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php",
                "line": 181,
                "function": "testResult",
                "class": "Icewind\\SMB\\Native\\NativeState",
                "type": "->",
                "args": [
                    false,
                    "smb://MyHost/MyUser/"
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php",
                "line": 113,
                "function": "stat",
                "class": "Icewind\\SMB\\Native\\NativeState",
                "type": "->",
                "args": [
                    "smb://MyHost/MyUser/"
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php",
                "line": 109,
                "function": "getStat",
                "class": "Icewind\\SMB\\Native\\NativeShare",
                "type": "->",
                "args": [
                    "/"
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php",
                "line": 164,
                "function": "stat",
                "class": "Icewind\\SMB\\Native\\NativeShare",
                "type": "->",
                "args": [
                    "/"
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php",
                "line": 264,
                "function": "getFileInfo",
                "class": "OCA\\Files_External\\Lib\\Storage\\SMB",
                "type": "->",
                "args": [
                    "/"
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/Files/Storage/Common.php",
                "line": 451,
                "function": "stat",
                "class": "OCA\\Files_External\\Lib\\Storage\\SMB",
                "type": "->",
                "args": [
                    ""
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php",
                "line": 578,
                "function": "test",
                "class": "OC\\Files\\Storage\\Common",
                "type": "->",
                "args": []
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/lib/config.php",
                "line": 240,
                "function": "test",
                "class": "OCA\\Files_External\\Lib\\Storage\\SMB",
                "type": "->",
                "args": [
                    false,
                    true
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/lib/Controller/StoragesController.php",
                "line": 256,
                "function": "getBackendStatus",
                "class": "OC_Mount_Config",
                "type": "::",
                "args": [
                    "\\OCA\\Files_External\\Lib\\Storage\\SMB",
                    {
                        "domain": "MyDomain",
                        "host": "MyHost",
                        "password": "MyPassword",
                        "root": "",
                        "share": "MyU	r",
                        "user": "MyUser",
                        "auth": {
                            "__class__": "Icewind\\SMB\\BasicAuth"
                        }
                    },
                    false,
                    true
                ]
            },
            {
                "file": "/var/www/nextcloud/apps/files_external/lib/Controller/UserStoragesController.php",
                "line": 207,
                "function": "updateStorageStatus",
                "class": "OCA\\Files_External\\Controller\\StoragesController",
                "type": "->",
                "args": [
                    {
                        "__class__": "OCA\\Files_External\\Lib\\StorageConfig"
                    },
                    true
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 166,
                "function": "update",
                "class": "OCA\\Files_External\\Controller\\UserStoragesController",
                "type": "->",
                "args": [
                    123,
                    "SMB",
                    "smb",
                    "password::password",
                    {
                        "host": "MyHost",
                        "share": "MyUser",
                        "root": "",
                        "domain": "MyDomain",
                        "user": "MyUser",
                        "password": "MyPassword"
                    },
                    {
                        "encrypt": true,
                        "previews": true,
                        "enable_sharing": false,
                        "filesystem_check_changes": 1,
                        "encoding_compatibility": false,
                        "readonly": false
                    },
                    true
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
                "line": 99,
                "function": "executeController",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [
                    {
                        "__class__": "OCA\\Files_External\\Controller\\UserStoragesController"
                    },
                    "update"
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/AppFramework/App.php",
                "line": 118,
                "function": "dispatch",
                "class": "OC\\AppFramework\\Http\\Dispatcher",
                "type": "->",
                "args": [
                    {
                        "__class__": "OCA\\Files_External\\Controller\\UserStoragesController"
                    },
                    "update"
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php",
                "line": 47,
                "function": "main",
                "class": "OC\\AppFramework\\App",
                "type": "::",
                "args": [
                    "OCA\\Files_External\\Controller\\UserStoragesController",
                    "update",
                    {
                        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
                    },
                    {
                        "id": "123",
                        "_route": "files_external.user_storages.update"
                    }
                ]
            },
            {
                "function": "__invoke",
                "class": "OC\\AppFramework\\Routing\\RouteActionHandler",
                "type": "->",
                "args": [
                    {
                        "id": "123",
                        "_route": "files_external.user_storages.update"
                    }
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/private/Route/Router.php",
                "line": 297,
                "function": "call_user_func",
                "args": [
                    {
                        "__class__": "OC\\AppFramework\\Routing\\RouteActionHandler"
                    },
                    {
                        "id": "123",
                        "_route": "files_external.user_storages.update"
                    }
                ]
            },
            {
                "file": "/var/www/nextcloud/lib/base.php",
                "line": 987,
                "function": "match",
                "class": "OC\\Route\\Router",
                "type": "->",
                "args": [
                    "/apps/files_external/userstorages/123"
                ]
            },
            {
                "file": "/var/www/nextcloud/index.php",
                "line": 42,
                "function": "handleRequest",
                "class": "OC",
                "type": "::",
                "args": []
            }
        ],
        "File": "/var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Exception/Exception.php",
        "Line": 30,
        "CustomMessage": "--"
    },
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0",
    "version": "15.0.2.0"
}

@MorrisJobke
Remove sensitive SMB arguments from exception log
e8739e1 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added bug 3. to review Waiting for reviews labels Mar 12, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 12, 2019
@MorrisJobke
Copy link
Member Author

/backport to stable15

@MorrisJobke
Copy link
Member Author

/backport to stable14

@faily-bot
Copy link

faily-bot bot commented Mar 12, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16928: failure

DB=sqlite, ENABLE_REDIS=false, PHP=7.3

Show full log 
There was 1 failure:

1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.

/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

TESTS=integration-federation_features

  • build/integration/federation_features/federated.feature:183
  • build/integration/federation_features/federated.feature:232
  • build/integration/federation_features/federated.feature:247
  • build/integration/federation_features/federated.feature:263
Show full log 
[Tue Mar 12 15:03:36 2019] 127.0.0.1:35110 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Tue Mar 12 15:03:36 2019] 127.0.0.1:35114 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Reshare a federated shared file                                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:183
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Tue Mar 12 15:03:36 2019] 127.0.0.1:43476 [404]: /ocs/v2.php/cloud/users/user1
[Tue Mar 12 15:03:36 2019] 127.0.0.1:43480 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:03:37 2019] 127.0.0.1:43488 [200]: /ocs/v1.php/cloud/users/user1
[Tue Mar 12 15:03:37 2019] 127.0.0.1:43492 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Tue Mar 12 15:03:37 2019] 127.0.0.1:43500 [404]: /ocs/v2.php/cloud/users/user2
[Tue Mar 12 15:03:38 2019] 127.0.0.1:43508 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:03:39 2019] 127.0.0.1:43532 [200]: /ocs/v1.php/cloud/users/user2
[Tue Mar 12 15:03:39 2019] 127.0.0.1:43556 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Tue Mar 12 15:03:39 2019] 127.0.0.1:35202 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:03:39 2019] 127.0.0.1:35206 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35212 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35216 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Tue Mar 12 15:03:40 2019] 127.0.0.1:43582 [200]: /ocm-provider/
[Tue Mar 12 15:03:40 2019] 127.0.0.1:43584 [201]: /index.php/ocm/shares
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35218 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Tue Mar 12 15:03:40 2019] 127.0.0.1:43588 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35236 [200]: //ocm-provider/
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35238 [201]: /index.php/ocm/notifications
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35240 [200]: //ocs-provider/
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35242 [200]: /ocs/v2.php/cloud/shares/8/accept?format=json
[Tue Mar 12 15:03:40 2019] 127.0.0.1:43592 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/9
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35246 [200]: //ocs-provider/
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35248 [200]: //status.php
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35250 [200]: //status.php
[Tue Mar 12 15:03:40 2019] 127.0.0.1:35252 [200]: /index.php/apps/files_sharing/shareinfo?t=OrS5dHWj3UvBLnx
[Tue Mar 12 15:03:40 2019] 127.0.0.1:43604 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                                                                          # FederationContext::creatingShare()
      | path        | /textfile0 (2).txt |
      | shareType   | 0                  |
      | shareWith   | user2              |
      | permissions | 19                 |
    Then the OCS status code should be "100"                                                            # FederationContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &00000000554ee55c000000004ad04be4 (
          0 => '404'
      ) matches expected '100'.
    And the HTTP status code should be "200"                                                            # FederationContext::theHTTPStatusCodeShouldBe()
    And Share fields of last share match with                                                           # FederationContext::checkShareFields()
      | id                     | A_NUMBER           |
      | item_type              | file               |
      | item_source            | A_NUMBER           |
      | share_type             | 0                  |
      | file_source            | A_NUMBER           |
      | path                   | /textfile0 (2).txt |
      | permissions            | 19                 |
      | stime                  | A_NUMBER           |
      | storage                | A_NUMBER           |
      | mail_send              | 1                  |
      | uid_owner              | user1              |
      | file_parent            | A_NUMBER           |
      | displayname_owner      | user1              |
      | share_with             | user2              |
      | share_with_displayname | user2              |
[Tue Mar 12 15:03:41 2019] 127.0.0.1:35256 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:03:41 2019] 127.0.0.1:35272 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:03:41 2019] 127.0.0.1:35308 [200]: //ocm-provider/
[Tue Mar 12 15:03:41 2019] 127.0.0.1:35312 [400]: /index.php/ocm/notifications
[Tue Mar 12 15:03:41 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 8"}

[Tue Mar 12 15:03:48 2019] 127.0.0.1:35590 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Tue Mar 12 15:03:48 2019] 127.0.0.1:35592 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:232
    Given Using server "REMOTE"                                                                          # FederationContext::usingServer()
[Tue Mar 12 15:03:48 2019] 127.0.0.1:43956 [404]: /ocs/v2.php/cloud/users/user1
[Tue Mar 12 15:03:49 2019] 127.0.0.1:43958 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:03:49 2019] 127.0.0.1:43960 [200]: /ocs/v1.php/cloud/users/user1
[Tue Mar 12 15:03:49 2019] 127.0.0.1:43972 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                              # FederationContext::assureUserExists()
[Tue Mar 12 15:03:50 2019] 127.0.0.1:43986 [404]: /ocs/v2.php/cloud/users/user2
[Tue Mar 12 15:03:50 2019] 127.0.0.1:44054 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:03:50 2019] 127.0.0.1:44068 [200]: /ocs/v1.php/cloud/users/user2
[Tue Mar 12 15:03:50 2019] 127.0.0.1:44080 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                              # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                             # FederationContext::usingServer()
[Tue Mar 12 15:03:50 2019] 127.0.0.1:35740 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:03:51 2019] 127.0.0.1:35746 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:03:51 2019] 127.0.0.1:35768 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:03:51 2019] 127.0.0.1:35796 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                              # FederationContext::assureUserExists()
[Tue Mar 12 15:03:51 2019] 127.0.0.1:44164 [200]: /ocm-provider/
[Tue Mar 12 15:03:51 2019] 127.0.0.1:44166 [201]: /index.php/ocm/shares
[Tue Mar 12 15:03:51 2019] 127.0.0.1:35802 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE"         # FederationContext::federateSharing()
[Tue Mar 12 15:03:52 2019] 127.0.0.1:44170 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Tue Mar 12 15:03:53 2019] 127.0.0.1:35828 [200]: //ocm-provider/
[Tue Mar 12 15:03:53 2019] 127.0.0.1:35832 [201]: /index.php/ocm/notifications
[Tue Mar 12 15:03:53 2019] 127.0.0.1:35834 [200]: //ocs-provider/
[Tue Mar 12 15:03:53 2019] 127.0.0.1:35836 [200]: /ocs/v2.php/cloud/shares/10/accept?format=json
[Tue Mar 12 15:03:53 2019] 127.0.0.1:44172 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/11
    And User "user1" from server "REMOTE" accepts last pending share                                     # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                            # FederationContext::usingServer()
    And As an "user1"                                                                                    # FederationContext::asAn()
    And User "user1" modifies text of "/textfile0.txt" with text "BLABLABLA"                             # FederationContext::modifyTextOfFile()
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35840 [200]: //ocs-provider/
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35842 [401]: /public.php/webdav/textfile0.txt
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35844 [404]: /public.php/webdav/textfile0.txt
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35846 [200]: //status.php
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35848 [200]: //status.php
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35850 [200]: /index.php/apps/files_sharing/shareinfo?t=ygnpMFlrA6auwHU
[Tue Mar 12 15:03:54 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Tue Mar 12 15:03:54 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35852 [207]: /public.php/webdav/
[Tue Mar 12 15:03:54 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35854 [200]: //status.php
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35856 [200]: //status.php
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35858 [200]: /index.php/apps/files_sharing/shareinfo?t=ygnpMFlrA6auwHU
[Tue Mar 12 15:03:54 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Tue Mar 12 15:03:54 2019] 127.0.0.1:44198 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt
    When User "user1" uploads file "../../data/user1/files/textfile0.txt" to "/PARENT (2)/textfile0.txt" # FederationContext::userUploadsAFileTo()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=0-8"                              # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "BLABLABLA"                                                        # FederationContext::downloadedContentShouldBe()
[Tue Mar 12 15:03:54 2019] 127.0.0.1:35860 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:03:55 2019] 127.0.0.1:35866 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:04:01 2019] 127.0.0.1:35916 [200]: //ocm-provider/
[Tue Mar 12 15:04:01 2019] 127.0.0.1:35918 [400]: /index.php/ocm/notifications
[Tue Mar 12 15:04:01 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 10"}

[Tue Mar 12 15:04:08 2019] 127.0.0.1:35962 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Tue Mar 12 15:04:08 2019] 127.0.0.1:35964 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared file as recipient using old chunking                           # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:247
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Tue Mar 12 15:04:08 2019] 127.0.0.1:44326 [404]: /ocs/v2.php/cloud/users/user1
[Tue Mar 12 15:04:08 2019] 127.0.0.1:44328 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:04:09 2019] 127.0.0.1:44330 [200]: /ocs/v1.php/cloud/users/user1
[Tue Mar 12 15:04:09 2019] 127.0.0.1:44332 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Tue Mar 12 15:04:09 2019] 127.0.0.1:44334 [404]: /ocs/v2.php/cloud/users/user2
[Tue Mar 12 15:04:09 2019] 127.0.0.1:44336 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:04:10 2019] 127.0.0.1:44338 [200]: /ocs/v1.php/cloud/users/user2
[Tue Mar 12 15:04:10 2019] 127.0.0.1:44340 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Tue Mar 12 15:04:10 2019] 127.0.0.1:35982 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:04:10 2019] 127.0.0.1:35984 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:04:11 2019] 127.0.0.1:35990 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:04:11 2019] 127.0.0.1:35992 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Tue Mar 12 15:04:11 2019] 127.0.0.1:44358 [200]: /ocm-provider/
[Tue Mar 12 15:04:11 2019] 127.0.0.1:44360 [201]: /index.php/ocm/shares
[Tue Mar 12 15:04:11 2019] 127.0.0.1:35994 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Tue Mar 12 15:04:11 2019] 127.0.0.1:44362 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36006 [200]: //ocm-provider/
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36008 [201]: /index.php/ocm/notifications
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36010 [200]: //ocs-provider/
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36012 [200]: /ocs/v2.php/cloud/shares/11/accept?format=json
[Tue Mar 12 15:04:11 2019] 127.0.0.1:44364 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/12
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36024 [200]: //ocs-provider/
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36026 [401]: /public.php/webdav/
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36030 [207]: /public.php/webdav/
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36034 [200]: //status.php
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36036 [200]: //status.php
[Tue Mar 12 15:04:11 2019] 127.0.0.1:36038 [200]: /index.php/apps/files_sharing/shareinfo?t=WGblG0oBLmkNd4o
[Tue Mar 12 15:04:11 2019] 127.0.0.1:44378 [404]: /remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/textfile0 (2).txt" with range "bytes=0-4"                                   # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AAAAA"                                                           # FederationContext::downloadedContentShouldBe()
[Tue Mar 12 15:04:12 2019] 127.0.0.1:36040 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:04:13 2019] 127.0.0.1:36050 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:04:14 2019] 127.0.0.1:36074 [200]: //ocm-provider/
[Tue Mar 12 15:04:14 2019] 127.0.0.1:36076 [400]: /index.php/ocm/notifications
[Tue Mar 12 15:04:14 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 11"}

[Tue Mar 12 15:04:14 2019] 127.0.0.1:36098 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Tue Mar 12 15:04:15 2019] 127.0.0.1:36100 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient using old chunking                  # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:263
    Given Using server "REMOTE"                                                                  # FederationContext::usingServer()
[Tue Mar 12 15:04:15 2019] 127.0.0.1:44462 [404]: /ocs/v2.php/cloud/users/user1
[Tue Mar 12 15:04:15 2019] 127.0.0.1:44464 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:04:17 2019] 127.0.0.1:44472 [200]: /ocs/v1.php/cloud/users/user1
[Tue Mar 12 15:04:18 2019] 127.0.0.1:44496 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                      # FederationContext::assureUserExists()
[Tue Mar 12 15:04:18 2019] 127.0.0.1:44498 [404]: /ocs/v2.php/cloud/users/user2
[Tue Mar 12 15:04:19 2019] 127.0.0.1:44500 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:04:19 2019] 127.0.0.1:44510 [200]: /ocs/v1.php/cloud/users/user2
[Tue Mar 12 15:04:19 2019] 127.0.0.1:44520 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                      # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                     # FederationContext::usingServer()
[Tue Mar 12 15:04:19 2019] 127.0.0.1:36164 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:04:20 2019] 127.0.0.1:36170 [200]: /ocs/v1.php/cloud/users
[Tue Mar 12 15:04:20 2019] 127.0.0.1:36172 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:04:20 2019] 127.0.0.1:36188 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                      # FederationContext::assureUserExists()
[Tue Mar 12 15:04:20 2019] 127.0.0.1:44558 [200]: /ocm-provider/
[Tue Mar 12 15:04:20 2019] 127.0.0.1:44560 [201]: /index.php/ocm/shares
[Tue Mar 12 15:04:20 2019] 127.0.0.1:36194 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Tue Mar 12 15:04:20 2019] 127.0.0.1:44568 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36224 [200]: //ocm-provider/
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36228 [201]: /index.php/ocm/notifications
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36230 [200]: //ocs-provider/
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36232 [200]: /ocs/v2.php/cloud/shares/12/accept?format=json
[Tue Mar 12 15:04:21 2019] 127.0.0.1:44572 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/13
    And User "user1" from server "REMOTE" accepts last pending share                             # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                    # FederationContext::usingServer()
    And As an "user1"                                                                            # FederationContext::asAn()
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36240 [200]: //ocs-provider/
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36246 [200]: //status.php
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36248 [200]: //status.php
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36252 [200]: /index.php/apps/files_sharing/shareinfo?t=k9QkVBFFzPyKIzD
[Tue Mar 12 15:04:21 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Tue Mar 12 15:04:21 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36254 [401]: /public.php/webdav/
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36256 [207]: /public.php/webdav/
[Tue Mar 12 15:04:21 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36262 [200]: //status.php
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36264 [200]: //status.php
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36266 [200]: /index.php/apps/files_sharing/shareinfo?t=k9QkVBFFzPyKIzD
[Tue Mar 12 15:04:21 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Tue Mar 12 15:04:21 2019] 127.0.0.1:44594 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=3-13"                    # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AABBBBBCCCC"                                              # FederationContext::downloadedContentShouldBe()
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36268 [200]: /ocs/v1.php/cloud/users/user0
[Tue Mar 12 15:04:21 2019] 127.0.0.1:36304 [404]: /ocs/v2.php/cloud/users/user0
[Tue Mar 12 15:04:22 2019] 127.0.0.1:36348 [200]: //ocm-provider/
[Tue Mar 12 15:04:22 2019] 127.0.0.1:36350 [400]: /index.php/ocm/notifications
[Tue Mar 12 15:04:22 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 12"}

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • tests/acceptance/features/app-comments.feature:10
Show full log 
  Scenario: open the comments for a different file           # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:10
    Given I am logged in                                     # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                 # FileListContext::iCreateANewFolderNamed()
    And I open the details view for "welcome.txt"            # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view        # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message        # CommentsAppContext::iSeeACommentWithAsMessage()
      Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    When I open the details view for "Folder"                # FileListContext::iOpenTheDetailsViewFor()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@rullzer rullzer merged commit c5c2192 into master Mar 13, 2019
@rullzer rullzer deleted the fix/noid/remove-sensitive-smb-values branch March 13, 2019 13:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 13, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #14658

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 13, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable14 in #14659

@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @rullzer @icewind1991