[app:files] Use current directory for hashing. #14674
Conversation
This fixes collisions that were causing uploads to break in a very terrible way. Kudos to @kesselb for finding the problematic place and to @hottwister for the proposed solution. Fixes nextcloud#10527.
|
Please keep in mind that these changes are only a part of the fix from owncloud. I'm still unsure if we need the other changes for something. |
|
@evilham could you please sign off your commits (check https://github.com/nextcloud/server/pull/14674/checks?check_run_id=77759184 for help)? |
@evilham Any chance that you can add this? |
|
Should also be fine without, because it's very little code change itself. |
|
/backport to stable15 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
backport to stable15 in #14762 |
|
Sorry for the delay and thank you for merging. Just as a comment: although I understand the motivation, I strongly disagree with the legal-name requirement; and indeed those bits of code are already unmistakeably under a compatible license. |
This fixes collisions that were causing uploads to break in a very
terrible way.
Kudos to @kesselb for finding the problematic place and to
@hottwister for the proposed solution.
Fixes #10527.
It would be great if this were backported to 15.0.