Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add casting to string for postgresql query builder #14683

Merged
merged 1 commit into from
Mar 14, 2019
Merged

add casting to string for postgresql query builder #14683

merged 1 commit into from
Mar 14, 2019

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991
add casting to string for postgresql query builder
bfd5390 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 14, 2019
@icewind1991 icewind1991 added this to the Nextcloud 16 milestone Mar 14, 2019
MorrisJobke
MorrisJobke approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

rullzer
rullzer approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 14, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16997: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:83
Show full log 
  Scenario: Install an app from the app store                     # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:83
    Given I act as Jane                                           # ActorContext::iActAs()
    And I am logged in as the admin                               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    And I click on the "Antivirus for files" app                  # AppsManagementContext::iClickOnTheApp()
    And I see that the app details are shown                      # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
    Then I download and enable the "Antivirus for files" app      # AppsManagementContext::iDownloadAndEnableTheApp()
    And I see that the "Antivirus for files" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

@MorrisJobke
Copy link
Member

  • tests/acceptance/features/apps.feature:83

"fixed" in #14681

@MorrisJobke MorrisJobke merged commit 2204d41 into master Mar 14, 2019
@MorrisJobke MorrisJobke deleted the postgres-cast-string branch March 14, 2019 15:45
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @MorrisJobke @rullzer