Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle long etags from dav external storage #14684

Merged
merged 1 commit into from
Mar 14, 2019
Merged

handle long etags from dav external storage #14684

merged 1 commit into from
Mar 14, 2019

Conversation

icewind1991
Copy link
Member

we can only store etags up to 40 characters long in the database, so when we get an etag that's longer we simply hash it to bring down the length

Signed-off-by: Robin Appelman robin@icewind.nl

we can only store etags up to 40 characters long in the database, so when we get an etag that's longer we simply hash it to bring down the length

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 14, 2019
@icewind1991 icewind1991 added this to the Nextcloud 16 milestone Mar 14, 2019
@icewind1991
Copy link
Member Author

/backport to stable15

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@rullzer rullzer merged commit f87bab8 into master Mar 14, 2019
@rullzer rullzer deleted the long-etag-dav branch March 14, 2019 16:18
@backportbot-nextcloud
Copy link

backport to stable15 in #14694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants