-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correct method for hardcoded /f/{fileid}
#14686
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Same wrong hack (route name method not matching the invoked method) was used in talk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
* @param string $fileid | ||
* @return TemplateResponse|RedirectResponse | ||
*/ | ||
public function showFile(string $fileid = null): Response { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17013: failureTESTS=acceptance, TESTS-ACCEPTANCE=apps
Show full log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
"fixed" in #14681 |
Regression from #14626
/f/{fileid}
link