Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an integration test that ensures deletion of LDAP users #14687

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 14, 2019

It sets the user filter to exclude a previously known user, checks for it's availability on LDAP and triggers the deletion process. It's a cumbersome procedure with prone to side effects in case of changes to some parts and thus worth ensuring to not run into regressions.

No production code is touched.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Mar 14, 2019

\backport to stable15

@faily-bot
Copy link

faily-bot bot commented Mar 14, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17000: failure

ENABLE_REDIS=true, TESTS=nodb-codecov

Show full log
There was 1 failure:

1) OCA\Files_Sharing\Tests\Controller\PublicPreviewControllerTest::testPreviewFile
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
-        'Expires' => 'Fri, 15 Mar 2019 16:24:34 +0000'
+        'Expires' => 'Fri, 15 Mar 2019 16:24:33 +0000'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/Controller/PublicPreviewControllerTest.php:140

TESTS=ui-regression

@juliusknorr
Copy link
Member

/backport to stable15

@backportbot-nextcloud
Copy link

backport to stable15 in #14697

@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants