Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate marked, escapeHTML, formatDate, getURLParameter, humanFileS… #14705

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Deprecate marked, escapeHTML, formatDate, getURLParameter, humanFileS… #14705

merged 1 commit into from
Mar 15, 2019

Conversation

skjnldsv
Copy link
Member

…ize, relative_modified_date and select2

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Mar 14, 2019
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Mar 14, 2019
@skjnldsv skjnldsv self-assigned this Mar 14, 2019
ChristophWurst
ChristophWurst approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@MorrisJobke
Copy link
Member

Would be nice to also print which method to use instead then.

@faily-bot
Copy link

faily-bot bot commented Mar 15, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17046: failure

TESTS=ui-regression

@MorrisJobke
Copy link
Member

Conflicts 🙈

@skjnldsv @rullzer
Deprecate marked, escapeHTML, formatDate, getURLParameter, humanFileS…
b4dd12e 
…ize, relative_modified_date and select2

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer rullzer force-pushed the deprecate/marked-escapeHTML-formatDate-getURLParameter-humanFileSize-relative_modified_date-select2 branch from f3e03e3 to b4dd12e Compare March 15, 2019 15:40
@rullzer rullzer merged commit f429098 into master Mar 15, 2019
@rullzer rullzer deleted the deprecate/marked-escapeHTML-formatDate-getURLParameter-humanFileSize-relative_modified_date-select2 branch March 15, 2019 17:08
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@danxuliu
Copy link
Member

Would be nice to also print which method to use instead then.

Even if it is not printed it would be good to at least have it documented in this pull request (just in case someone else besides me ends here when checking the commit history ;-) ); @skjnldsv could you mention which functions should be used instead? Thanks :-)

@ChristophWurst
Copy link
Member

I think there was an existing npm package that does exactly what our function did. @skjnldsv what was its name?

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 26, 2019 •
edited
Loading

@ChristophWurst for the escapeHtml?
https://www.npmjs.com/package/escape-html

@ChristophWurst
Copy link
Member

Published 4 years ago

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 26, 2019 •
edited
Loading

Well, it's such a simple library I don't really see what you can do more to upgrade it xD

Still maintained https://github.com/component/escape-html

@ChristophWurst
Copy link
Member

oh, lol, yes https://github.com/component/escape-html/blob/master/index.js#L33-L78 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @MorrisJobke @danxuliu @ChristophWurst @rullzer