Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user creation using LDAP Plugin #14778

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Conversation

MorrisJobke
Copy link
Member

Same as #12452 but rebased on master.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
This commit fix an error happening when the subadmin tries to create an
user, adding him/her to the group s/he is subadmin of, using a LDAP
User/Group plugin.

This just forces the cache to be reset after an user is added to a
group.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
LDAP plugins must change the createUser method to return the DN, as we
need this to update the cache.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 21, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 21, 2019
@MorrisJobke MorrisJobke requested a review from blizzz March 21, 2019 09:22
@MorrisJobke
Copy link
Member Author

/backport to stable15

@MorrisJobke
Copy link
Member Author

/backport to stable14

@MorrisJobke
Copy link
Member Author

Reviews for this are in #12452

@MorrisJobke MorrisJobke merged commit 0155edc into master Mar 21, 2019
@MorrisJobke MorrisJobke deleted the user_ldap_createuser_fix branch March 21, 2019 10:32
@MorrisJobke MorrisJobke mentioned this pull request Mar 21, 2019
9 tasks
@backportbot-nextcloud
Copy link

backport to stable15 in #14781

@backportbot-nextcloud
Copy link

backport to stable14 in #14782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants