[stable14] Avoid replacement by user object

[MorrisJobke]

Backport of #14058

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17330: failure

ENABLE_REDIS=true, TESTS=nodb-codecov

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=true, PHP=7.0

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=true, PHP=7.1

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=false, PHP=7.2

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=false, PHP=7.3

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

• tests/acceptance/features/app-files.feature:108

Show full log

  Scenario: show shares                                               # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

TESTS=sqlite-php7.0-samba-non-native

Show full log

There was 1 failure:

1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges
Actual changes are:
Array
(
    [0] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 1
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [1] => OC\Files\Notify\RenameChange Object
        (
            [targetPath:OC\Files\Notify\RenameChange:private] => renamed.txt
            [type:OC\Files\Notify\Change:private] => 4
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [2] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 2
            [path:OC\Files\Notify\Change:private] => renamed.txt
        )

)

Failed asserting that an array contains OC\Files\Notify\RenameChange Object &0000000046887b72000000007e594cab (
    'targetPath' => 'renamed.txt'
    'type' => 4
    'path' => 'newfile.txt'
).

/drone/src/github.com/nextcloud/server/apps/files_external/tests/Storage/SmbTest.php:124

TESTS=ui-regression

• I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you