Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent a reinstall #14965

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Prevent a reinstall #14965

merged 1 commit into from
Apr 11, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 4, 2019 •
edited
Loading

No description provided.

@rullzer rullzer added enhancement 2. developing Work in progress labels Apr 4, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Apr 4, 2019
@MorrisJobke
Copy link
Member

[ ] Maybe a check in the admin settings?

for what? if the file is present? but the updater should remove it, right?

@nickvergessen
Copy link
Member

I vote for a bypass on update channel git.
Otherwise this will be a pain for developers.

You always remove the file and commit it by accident and you need to recreate it, in order to be able to reinstall

@rullzer
Copy link
Member Author

rullzer commented Apr 5, 2019

I vote for a bypass on update channel git.
Otherwise this will be a pain for developers.

You always remove the file and commit it by accident and you need to recreate it, in order to be able to reinstall

yes that was also my idea 👍

@rullzer
Copy link
Member Author

rullzer commented Apr 8, 2019

Done I think

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 9, 2019
@rullzer rullzer mentioned this pull request Apr 10, 2019
Merged
13 tasks
ChristophWurst
ChristophWurst reviewed Apr 10, 2019
View reviewed changes
core/Controller/SetupController.php Outdated Show resolved Hide resolved
lib/private/Updater.php Outdated Show resolved Hide resolved
lib/private/Updater.php Outdated Show resolved Hide resolved
@rullzer
Block install without CAN_INSTALL file
7e7146d 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2019
@MorrisJobke MorrisJobke merged commit ef06c3f into master Apr 11, 2019
@MorrisJobke MorrisJobke deleted the enh/install_file branch April 11, 2019 08:19
@rullzer
Copy link
Member Author

rullzer commented Apr 15, 2019

/backport to stable15

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 15, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #15112

@nickvergessen
Copy link
Member

Was merged before stable16 right?

@ChristophWurst
Copy link
Member

Yes: https://github.com/nextcloud/server/blob/stable16/config/CAN_INSTALL

@GuyPaddock GuyPaddock mentioned this pull request Feb 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@schiessle schiessle Awaiting requested review from schiessle

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @MorrisJobke @nickvergessen @ChristophWurst