Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing in list: Use .hidden-visually instead of display:none for accessibility, fix #11661 #15961

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Sharing in list: Use .hidden-visually instead of display:none for accessibility, fix #11661 #15961

merged 1 commit into from
Jun 17, 2019

Conversation

jancborchardt
Copy link
Member

Fix #11661, please review @nextcloud/accessibility @nextcloud/designers

And thanks to @javido @tyrylu for reporting! (This is still quite old code and we hope to replace it with the new Vue components soon. :)

Also could make sense to backport to 16, what do you think?

@jancborchardt
Sharing in list: Use .hidden-visually instead of display:none for acc…
42a84ea 
…essibility, fix #11661

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added this to the Nextcloud 17 milestone Jun 14, 2019
@jancborchardt jancborchardt mentioned this pull request Jun 14, 2019
Closed
javido
javido approved these changes Jun 14, 2019
View reviewed changes
Copy link

@javido javido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, now I have tested this request and fixed the issue with "Share" link accessibility in Master.
would be nice to have it in 16.x version if it's possible.
Many thanks!

@jancborchardt
Copy link
Member Author

/backport to stable16

tyrylu
tyrylu approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@tyrylu tyrylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these. They will help.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 17, 2019
@skjnldsv skjnldsv merged commit f6ad353 into master Jun 17, 2019
@skjnldsv skjnldsv deleted the design/sharing-accessibility branch June 17, 2019 08:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 17, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #15981

@jancborchardt
Copy link
Member Author

@tyrylu @javido thanks a lot for reporting, and again sorry for the issue in the first place! Please don’t hesitate to report more if anything comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrylu tyrylu tyrylu approved these changes

@javido javido javido approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: accessibility feature: sharing high
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.

Sharing UI accessibility
4 participants
@jancborchardt @javido @tyrylu @skjnldsv