Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to provide supported calendar component set internally as a string #16503

Merged

Conversation

georgehrke
Copy link
Member

To test:

  • delete your contact's birthday calendar
  • run php occ dav:sync-birthday-calendar
  • check components row in database

On master it's VEVENT,VTODO
(the default value from

'components' => 'VEVENT,VTODO',
)

On this branch it's VEVENT
(as intended in

'components' => 'VEVENT',
)

fixes #5504

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Jul 22, 2019
@georgehrke georgehrke requested review from tcitworld and skjnldsv July 22, 2019 15:01
@georgehrke
Copy link
Member Author

/backport to stable16

@georgehrke
Copy link
Member Author

/backport to stable15

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 25, 2019
@rullzer rullzer merged commit c504ed6 into master Jul 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/5504/create_new_birthday_calendars_with_VEVENT_only branch July 25, 2019 11:36
@backportbot-nextcloud
Copy link

backport to stable16 in #16536

@backportbot-nextcloud
Copy link

backport to stable15 in #16537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Contacts Birthdays' showing up as task list
4 participants