Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the UID is correctly cased #1766

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

nickvergessen
Copy link
Member

Try to transfer files from user test1 to test2 with the command occ files:transfer-ownership Test1 Test2

@MorrisJobke @LukasReschke

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @LukasReschke and @carlaschroder to be potential reviewers.

@LukasReschke
Copy link
Member

👍

@MorrisJobke
Copy link
Member

Doesn't work for me - the transfer then doesn't work at all after checking out this branch. No folder transferred from test1 on 2016-10-17T11:22:25+00:00 is created with this branch even if the correct naming is used. 👎

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the force-uid-casing-on-transfer-ownership branch from 41d1530 to 77a5491 Compare October 17, 2016 11:42
@nickvergessen
Copy link
Member Author

Fixed

@MorrisJobke
Copy link
Member

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 17, 2016
@codecov-io
Copy link

Current coverage is 57.26% (diff: 0.00%)

Merging #1766 into master will decrease coverage by <.01%

@@             master      #1766   diff @@
==========================================
  Files          1075       1075          
  Lines         61274      61278     +4   
  Methods        6864       6864          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          35093      35093          
- Misses        26181      26185     +4   
  Partials          0          0          

Sunburst

Diff Coverage File Path
0% apps/files/lib/Command/TransferOwnership.php

Powered by Codecov. Last update 96f8f20...77a5491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants