Switch to SCSS #1805

skjnldsv · 2016-10-19T15:31:48Z

This is related to #1786
Please only use this pr to discuss issues or comments about its commits.

For arguing and/or ask question, go to the issue.

mention-bot · 2016-10-19T15:31:50Z

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @bartv2 and @owncloud-bot to be potential reviewers.

MorrisJobke · 2016-10-19T15:35:33Z

lib/private/Template/SCSSCacher.php

@@ -0,0 +1,113 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016, nextCloud, Inc.


Nope, the copyright belongs to you ;)

Well, if you insist! :3

MorrisJobke · 2016-10-19T15:40:23Z

lib/private/Template/SCSSCacher.php

+	}
+}
+
+?>


No need to close this here - just remove this. This also reduces possible issues with whitespace after the closing tag that cause a different output to the browser.

rullzer · 2016-10-19T17:42:44Z

Please use the AppData to store stuff. Don't go writing into folders.

LukasReschke · 2016-10-19T18:08:18Z

Please use the AppData to store stuff. Don't go writing into folders.

So store in AppData and use PHP to serve and set proper caching headers? We can't assume that assets is writable at the moment :)

rullzer · 2016-10-19T18:48:19Z

@LukasReschke exactly

skjnldsv · 2016-10-19T19:03:50Z

Sure! No problem! 😃

nickvergessen · 2016-10-20T08:14:16Z

lib/private/Template/SCSSCacher.php

+ *
+ * @author John Molakvoæ <skjnldsv@protonmail.com>
+ *
+ * @license AGPL-3.0


Can you use the header from https://github.com/nextcloud/server/blob/master/contribute/HowToApplyALicense.md#how-to-apply-a-license ?

Of course! 😃

skjnldsv · 2016-10-20T16:24:35Z

core/css/share.scss

+	width: 90%;
+}
+
+.ui-autocomplete {


@jancborchardt why don't we have a global definition for this? Shouldn't the dropdown use select2? :)

Opened a separate issue about that at #1831 ;)

jancborchardt · 2016-10-20T16:46:27Z

Btw @skjnldsv while we rewrite the whole file to new syntax and all the author info is lost, we should probably add the copyright headers at this point to each file. :)

skjnldsv · 2016-10-20T16:48:58Z

we should probably add the copyright headers at this point to each file. :)

NO! NO COPIRIT FOR U!

Yeah, I saw that. I will readd all the copyright after with a unified header so it looks good 😉

jancborchardt · 2016-10-21T10:16:48Z

lib/private/Template/SCSSCacher.php

 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the


@nickvergessen why the extra space here?

I copied the header from https://github.com/nextcloud/server/blob/master/contribute/HowToApplyALicense.md

Signed-off-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

…o core Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

rullzer · 2016-11-08T09:01:33Z

@skjnldsv what is the progress here?

Any chance of breaking it up into smaller PR's As reviewing 1800 lines is kind of a pain.

skjnldsv · 2016-11-08T09:10:30Z

No chance at all! 😂 😂
I know this is a lot of work, but imagine what I had to do 😆

The best way to check this pr i think will be to check the validity of the generated css, and then explore your nextcloud installation looking for mistakes (which I already did and try to check everytime I make a small change) 😕

Concerning the progress, It's going fast I think. I'm almost done converting, and the next big thing will be the appdata integration (see original issue)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

juliusknorr · 2016-11-08T10:54:52Z

@rullzer @skjnldsv https://codeascraft.com/2015/02/02/transitioning-to-scss-at-scale/#scss-diff might be interesting to check if the resulting css code has fundamental changes.

skjnldsv · 2016-11-08T11:44:03Z

@juliushaertl Indeed! I wonder if I shouldn't listen to @rullzer and create separate commits.
One with the scss implementation and a basic conversion, and multiples seconds with each one a simplification. I should have done that since the beginning! 😢

juliusknorr · 2016-11-08T11:48:51Z

@skjnldsv Creating separate PRs should not be that hard, just create a new branch and cherry pick the commits you need from this one.

MorrisJobke · 2017-01-06T13:49:34Z

@skjnldsv Is this still needed?

skjnldsv · 2017-01-06T14:03:18Z

@MorrisJobke probably not!

skjnldsv added enhancement help wanted design Design, UI, UX, etc. 2. developing Work in progress labels Oct 19, 2016

skjnldsv added this to the Nextcloud 11.0 milestone Oct 19, 2016

skjnldsv self-assigned this Oct 19, 2016

MorrisJobke reviewed Oct 19, 2016

View reviewed changes

nickvergessen reviewed Oct 20, 2016

View reviewed changes

skjnldsv commented Oct 20, 2016

View reviewed changes

skjnldsv mentioned this pull request Oct 20, 2016

Unify select mechanisms/widgets #1831

Open

17 tasks

jancborchardt reviewed Oct 21, 2016

View reviewed changes

skjnldsv force-pushed the scss-switch branch 2 times, most recently from ed745d2 to d7902cb Compare October 22, 2016 03:57

skjnldsv added 9 commits November 2, 2016 10:41

Cache and compile base

fac117b

Copyright update

adfdc33

EOF fix

ed747db

Inputs select2 fix

f9d460c

Inputs select2 fix 2

8b582de

Copyright fix

dac10d2

Tooltip scss

93c8dfe

Systemtags scss

64173a4

Share scss (remove .showCruds related since we don't use it anymore)

4ed1f56

skjnldsv and others added 7 commits November 2, 2016 10:43

Removing old css

00f7e84

Icons scss

861d232

Icons scss fix loading gif and added audio

17cd40f

Icons scss fix loading elements gif

cf47f9d

Update rest of the header as well

b758066

Signed-off-by: Joas Schilling <coding@schilljs.com>

Apps scss

6f4b60f

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Rebase master and applied 2d91831 & bd7abc2

c4dd6f0

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv force-pushed the scss-switch branch from d7902cb to c4dd6f0 Compare November 2, 2016 09:49

skjnldsv added 5 commits November 5, 2016 09:08

Inputs global fix and improvments

6d9c569

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Inputs primary button

58b431d

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Inputs border fix

67c63e9

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Inputs select2 important fix following select2 vendor style merging t…

05c0aa0

…o core Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Jquery-ui-fixes

942c1dd

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Inputs select2 float, dropdown and border fix #1932

d0a5fc6

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv force-pushed the scss-switch branch from 4a70966 to d0a5fc6 Compare November 8, 2016 09:29

skjnldsv mentioned this pull request Nov 8, 2016

Switch to SCSS: base files #2050

Merged

MorrisJobke mentioned this pull request Nov 23, 2016

NextCloud is unacceptably slow without asset pipelining #2272

Closed

MorrisJobke modified the milestones: Nextcloud 12.0, Nextcloud 11.0 Nov 24, 2016

skjnldsv closed this Jan 6, 2017

rullzer deleted the scss-switch branch January 6, 2017 14:03

skjnldsv mentioned this pull request Jan 10, 2017

Fixed installation page #3004

Merged

skjnldsv added the feature: scss label Jan 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to SCSS #1805

Switch to SCSS #1805

skjnldsv commented Oct 19, 2016

mention-bot commented Oct 19, 2016

MorrisJobke Oct 19, 2016

skjnldsv Oct 19, 2016

MorrisJobke Oct 19, 2016

rullzer commented Oct 19, 2016

LukasReschke commented Oct 19, 2016

rullzer commented Oct 19, 2016

skjnldsv commented Oct 19, 2016

nickvergessen Oct 20, 2016

skjnldsv Oct 20, 2016

skjnldsv Oct 20, 2016

jancborchardt Oct 20, 2016

skjnldsv Oct 20, 2016

jancborchardt commented Oct 20, 2016

skjnldsv commented Oct 20, 2016 •

edited

Loading

jancborchardt Oct 21, 2016

nickvergessen Oct 21, 2016

skjnldsv Oct 21, 2016

rullzer commented Nov 8, 2016

skjnldsv commented Nov 8, 2016

juliusknorr commented Nov 8, 2016

skjnldsv commented Nov 8, 2016

juliusknorr commented Nov 8, 2016

MorrisJobke commented Jan 6, 2017

skjnldsv commented Jan 6, 2017

+              	}
+              }
+              ?>

Switch to SCSS #1805

Switch to SCSS #1805

Conversation

skjnldsv commented Oct 19, 2016

mention-bot commented Oct 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rullzer commented Oct 19, 2016

LukasReschke commented Oct 19, 2016

rullzer commented Oct 19, 2016

skjnldsv commented Oct 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jancborchardt commented Oct 20, 2016

skjnldsv commented Oct 20, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rullzer commented Nov 8, 2016

skjnldsv commented Nov 8, 2016

juliusknorr commented Nov 8, 2016

skjnldsv commented Nov 8, 2016

juliusknorr commented Nov 8, 2016

MorrisJobke commented Jan 6, 2017

skjnldsv commented Jan 6, 2017

skjnldsv commented Oct 20, 2016 •

edited

Loading