-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow admin to configure the max trashbin size #21658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine
1a29e1d
to
02dede4
Compare
done |
this allows an admin to configure the max trashbin size instead of always relying on the users quota. The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user Signed-off-by: Robin Appelman <robin@icewind.nl>
02dede4
to
050e2fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
/backport to stable19 |
/backport to stable18 |
I suppose command should be |
That's just a typo I guess. The code says so as well: https://github.com/nextcloud/server/pull/21658/files#diff-4deaa41582a337ef216fd10850de68b4R56 |
When it will be documented? |
@GAS85 Mind to add it to the documentation repository issue tracker or directly edit the documentation page and add it there? That would help a lot and we can review and include it. |
@MorrisJobke glad to do it, but syntax is not clear to me, e.g.
User and Size are clear, but what is output? |
Any update here?
|
this allows an admin to configure the max trashbin size instead of always relying on the users quota.
The trashbin size can be configured using the
occ trash:size
command and can be set both globally and per-userSigned-off-by: Robin Appelman robin@icewind.nl