Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow admin to configure the max trashbin size #21658

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

icewind1991
Copy link
Member

this allows an admin to configure the max trashbin size instead of always relying on the users quota.

The trashbin size can be configured using the occ trash:size command and can be set both globally and per-user

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 2, 2020
@icewind1991 icewind1991 added this to the Nextcloud 20 milestone Jul 2, 2020
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine

apps/files_trashbin/lib/Command/Size.php Outdated Show resolved Hide resolved
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 6, 2020
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 7, 2020
@icewind1991
Copy link
Member Author

done

this allows an admin to configure the max trashbin size instead of always relying on the users quota.

The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user

Signed-off-by: Robin Appelman <robin@icewind.nl>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke merged commit 7b250db into master Jul 21, 2020
@MorrisJobke MorrisJobke deleted the trashbin-configurable-size branch July 21, 2020 18:46
@icewind1991
Copy link
Member Author

/backport to stable19

@icewind1991
Copy link
Member Author

/backport to stable18

@GAS85
Copy link

GAS85 commented Sep 14, 2020

I suppose command should be occ trashbin:size, not occ trash:size. Reference https://docs.nextcloud.com/server/19/admin_manual/configuration_server/occ_command.html#trashbin

@MorrisJobke
Copy link
Member

The trashbin size can be configured using the occ trash:size command and can be set both globally and per-user

That's just a typo I guess.

The code says so as well: https://github.com/nextcloud/server/pull/21658/files#diff-4deaa41582a337ef216fd10850de68b4R56

@GAS85
Copy link

GAS85 commented Mar 11, 2021

When it will be documented?

@MorrisJobke
Copy link
Member

@GAS85 Mind to add it to the documentation repository issue tracker or directly edit the documentation page and add it there? That would help a lot and we can review and include it.

@GAS85
Copy link

GAS85 commented Mar 18, 2021

@MorrisJobke glad to do it, but syntax is not clear to me, e.g.

trashbin:size [--output [OUTPUT]] [-u|--user USER] [--] [<size>]

User and Size are clear, but what is output?
Also size in %? How to put unlimited? From the code seems via negative value, but I'm not sure here 😞

@GAS85
Copy link

GAS85 commented Jun 17, 2021

Any update here?
Was "playing" with settings to understand it and drop the hole limits to 0 that deletes all users trashin content...
So please, write the documentation:

  • explain how to set e.g. 50% of quote.
  • how to set for all users
  • how to set absolute e.g. in GB, KB, MB...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants