Add removal of mounts without storages to files:cleanup command #21729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
rullzer,
nickvergessen,
MorrisJobke and
icewind1991
nickvergessen
approved these changes
Jul 7, 2020
|
PHPUnit fails |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
Failure should be fixed and I also covered the mount cleanup in the test case now |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to filecache entries there might be orphaned entries in the oc_mounts table that are not removed if a storage is no longer available (e.g. when removing an external storage entry). Therefore this PR adds the cleanup of those to the
occ files:cleanupcommand.