adding social profile to search index

[call-me-matt]

required in order to optimize regular background updates of contact avatars from social networks (see nextcloud/contacts#1722 (comment))

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31295: failure

integration-provisioning-v1

• build/integration/features/provisioning-v1.feature:322

Show full log

  Scenario: get enabled apps                           # /drone/src/build/integration/features/provisioning-v1.feature:322
    Given As an "admin"                                # FeatureContext::asAn()
[Sun Aug  2 12:21:43 2020] 127.0.0.1:40142 [200]: /ocs/v1.php/cloud/apps?filter=enabled
    When sending "GET" to "/cloud/apps?filter=enabled" # FeatureContext::sendingTo()
    Then the OCS status code should be "100"           # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"           # FeatureContext::theHTTPStatusCodeShouldBe()
    And apps returned are                              # FeatureContext::theAppsShouldBe()
      | accessibility           |
      | cloud_federation_api    |
      | comments                |
      | contactsinteraction     |
      | dashboard               |
      | dav                     |
      | federatedfilesharing    |
      | federation              |
      | files                   |
      | files_sharing           |
      | files_trashbin          |
      | files_versions          |
      | lookup_server_connector |
      | provisioning_api        |
      | settings                |
      | sharebymail             |
      | systemtags              |
      | theming                 |
      | twofactor_backupcodes   |
      | updatenotification      |
      | user_ldap               |
      | viewer                  |
      | workflowengine          |
      | files_external          |
      | oauth2                  |
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
      -    23 => 'viewer'
      -    24 => 'workflowengine'
      +    23 => 'user_status'
      +    24 => 'viewer'
      +    25 => 'workflowengine'
[Sun Aug  2 12:21:43 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Sun Aug  2 12:21:43 2020] 127.0.0.1:40176 [401]: /remote.php/webdav/myFileToComment.txt
[Sun Aug  2 12:21:43 2020] 127.0.0.1:40178 [207]: /remote.php/dav/systemtags/
[Sun Aug  2 12:21:43 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Sun Aug  2 12:21:43 2020] 127.0.0.1:40200 [401]: /remote.php/webdav/myFileToTag.txt
[Sun Aug  2 12:21:44 2020] 127.0.0.1:40206 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Sun Aug  2 12:21:44 2020] 127.0.0.1:40224 [404]: /remote.php/dav/calendars/admin/MyCalendar

[skjnldsv]

Can we backport? 🤔

[nickvergessen]

Hmm this only works for new entries. Do we have a way to quickly trigger a reupdate of all entries?

[skjnldsv]

Hmm this only works for new entries. Do we have a way to quickly trigger a reupdate of all entries?

no idea :/

[georgehrke]

Do we have a way to quickly trigger a reupdate of all entries?

This is what we did back then for CalDAV:

https://github.com/nextcloud/server/blob/master/apps/dav/lib/Migration/BuildCalendarSearchIndex.php
https://github.com/nextcloud/server/blob/master/apps/dav/lib/Migration/BuildCalendarSearchIndexBackgroundJob.php

[call-me-matt]

this only works for new entries

wow, you are right! I did not realize that before.
I could trigger a re-index whenever my option is activated by the user (default is off). So for my use case it would work.

[nickvergessen]

wow, you are right! I did not realize that before.
I could trigger a re-index whenever my option is activated by the user (default is off). So for my use case it would work.

Or you copy what georg did for the calendar?

[rullzer]

So what do we do here?

[georgehrke]

@call-me-matt Can you implement something similar to what I did back then for CalDAV?

It's fine to do it once on upgrade, no need to do it every time a user enables/disables the option.

It would be good to optimize the SQL query and only reindex vCards that actually contain X-SOCIALPROFILE in the carddata.

[call-me-matt]

I'd say we should add the social profile to the search index and I'll take it as an action for the contacts app to re-index.
... I suppose it has to be done in the contacts app? or is it also in dav where I need to place the re-indexing?

[call-me-matt]

@MorrisJobke modified the milestones: Nextcloud 20, Nextcloud 21 yesterday

oh, it's not coming in NCv20 anymore? how come, is there anything missing?

[skjnldsv]

oh, it's not coming in NCv20 anymore? how come, is there anything missing?

We're passed the feature freeze :)
Beta1 has been released