Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2408 #2412

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Fix #2408 #2412

merged 1 commit into from
Nov 29, 2016

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 29, 2016

Checked with ff and chrome.

@ChristophWurst

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Nov 29, 2016
@skjnldsv skjnldsv added this to the Nextcloud 11.0 milestone Nov 29, 2016
@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @MorrisJobke and @icewind1991 to be potential reviewers.

@ChristophWurst
Copy link
Member

Still looks a lot different on FF and Chrome

bildschirmfoto von 2016-11-29 17-46-05

I can even unset the padding-bottom on FF and it looks the same :-/

@skjnldsv
Copy link
Member Author

Looks good here
can't do much abou tthe ugly scrollbar though.
capture d ecran_2016-11-29_17-54-28
capture d ecran_2016-11-29_17-54-35

@ChristophWurst
Copy link
Member

👍

1 similar comment
@icewind1991
Copy link
Member

👍

@LukasReschke
Copy link
Member

@skjnldsv Commits are not signed-off 😉

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the filepicker-bottom-padding-fix branch from bf338e0 to 506c981 Compare November 29, 2016 17:37
@skjnldsv
Copy link
Member Author

Tsss :)

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 29, 2016
@ChristophWurst ChristophWurst merged commit 83cef4e into master Nov 29, 2016
@ChristophWurst ChristophWurst deleted the filepicker-bottom-padding-fix branch November 29, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants