Add deck share provider support #24605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
juliusknorr
force-pushed
the
enh/share-deck
branch
2 times, most recently
from
e5533e7 to
4ac2cbb
Compare
juliusknorr
requested review from
ChristophWurst,
nickvergessen,
rullzer and
danxuliu
juliusknorr
commented
Dec 8, 2020
Comment on lines
+321
to
+322
| } elseif ($shareType === IShare::TYPE_DECK) { | ||
| $provider = $this->getProvider('deck'); |
There was a problem hiding this comment.
We could also extend the share manager to allow registering a share provider together with a shareType, then at least the provider registration could be done without having additional code in server (except for the actual shareType constant), but i kept that for later to not overcomplicate this pr.
There was a problem hiding this comment.
'deck' is the identifier of the share provider https://github.com/nextcloud/deck/pull/2638/files#diff-bfa062609a398b64ebc3167faba3abbca19b04da0c1e3f3dd033fa6babaebbc4R100-R102 that basically implies that IShare::TYPE_DECK is used.
apps/files_sharing/lib/Controller/DeletedShareAPIController.php
Outdated
Show resolved
Hide resolved
nickvergessen
approved these changes
Dec 9, 2020
rullzer
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Please check the comments from @nickvergessen but fine by me
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…to have a link Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/share-deck
branch
from
989f675 to
1fd2298
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/share-deck
branch
from
1fd2298 to
c4ea37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the share manager to allow apps registering their own share providers and implements support for deck shares in places where handing over the logic to the apps is yet not possible. Basically the parts where the server still needs app based logic is mainly the share api and the sharing sidebar in files.
Heavily inspired by #10255
Server part of nextcloud/deck#2638 This can already be tested together for the share provider logic, however the deck side is still lacking the user interface to interact with the shares and upload/share files from within deck.