Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.0.6 #25294

Merged
merged 1 commit into from
Jan 25, 2021
Merged

20.0.6 #25294

merged 1 commit into from
Jan 25, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 23, 2021

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added 2. developing Work in progress overview labels Jan 23, 2021
@rullzer rullzer added this to the Nextcloud 20.0.6 milestone Jan 23, 2021
@faily-bot
Copy link

faily-bot bot commented Jan 23, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1629: failure

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:23
Show full log
  Scenario: share a file with another user that needs to accept shares        # /drone/src/tests/acceptance/features/app-files-sharing.feature:23
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I visit the settings page                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section                                          # AppNavigationContext::iOpenTheSection()
    And I disable accepting the shares by default                             # SettingsContext::iDisableAcceptingTheSharesByDefault()
    And I see that shares are not accepted by default                         # SettingsContext::iSeeThatSharesAreNotAcceptedByDefault()
    And I act as John                                                         # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                              # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I share "farewell.txt" with "user0"                                  # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    And I see that the file list does not contain a file named "farewell.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
    And I accept the share for "/farewell.txt" in the notifications           # NotificationsContext::iAcceptTheShareForInTheNotifications()
      Notifications button in the header could not be found after 100 seconds (NoSuchElementException)
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "farewell.txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "farewell.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

acceptance-header

  • tests/acceptance/features/header.feature:33
Show full log
  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:33
    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                                                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
      Failed asserting that true is false.
    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@LecrisUT
Copy link

Could you also include these 2 commits from #25214?

@rullzer
Copy link
Member Author

rullzer commented Jan 25, 2021

Could you also include these 2 commits from #25214?

* [d751fed](https://github.com/nextcloud/server/commit/d751fedffb110aca956e9f786cd9ecdafdfa6ecd)

* [fcbbcac](https://github.com/nextcloud/server/commit/fcbbcacab4dc0178c7fdf1a61cfb81f922c60209)

I fail to see how those would help on 20 as we there did not upgrade phpseclib

@LecrisUT
Copy link

I've reported in #25243 that due to an update in 20.0.5 (or maybe even earlier), the certificate verification fails. The relevant commits that fix it are above, and are independent of phpsec update, it's just that it is first fixed in that PR.

@rullzer
Copy link
Member Author

rullzer commented Jan 25, 2021

I've reported in #25243 that due to an update in 20.0.5 (or maybe even earlier), the certificate verification fails. The relevant commits that fix it are above, and are independent of phpsec update, it's just that it is first fixed in that PR.

But then there is something else at play. Because I just checked and on 3 test system 20.0.5 validates just fine.

@LecrisUT
Copy link

I've updated 2 production instances and this problem occurred in both of them. According to the open issue others have the same problem.

At the very least those changes are backwards compatible, and will not break anything if included.

@rullzer
Copy link
Member Author

rullzer commented Jan 25, 2021

I've updated 2 production instances and this problem occurred in both of them. According to the open issue others have the same problem.

They are all on 21.
I'll check but the tagging and building of this release is very close. So else it will be 20.0.7

@rullzer rullzer merged commit fd26cb1 into stable20 Jan 25, 2021
@rullzer rullzer deleted the version/20.0.6/final branch January 25, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants