Fix "searchUsers" usage in Group_LDAP.php #25318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Access::searchUsers` expects an array as the second parameter, `Group_LDAP.php` called the method with a simple string, resulting in an exception and preventing folders shared with dynamic groups from working. This trivial change fixes the usage in Group_LDAP. Fixes #25163 Signed-off-by: Henning Hoefer <hho@users.noreply.github.com>
blizzz
approved these changes
Mar 17, 2021
|
/backport to stable21 |
|
/backport to stable20 |
|
/backport to stable19 |
|
@hho thank you for the fix! :) |
ChristophWurst
approved these changes
Mar 30, 2021
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
|
The backport to stable19 failed. Please do this backport manually. |
|
@blizzz backports failed :( |
|
Probably just overwriting the change from the mentioned PR which was merged only few days after this PR here was opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access::searchUsersexpects an array as the second parameter,Group_LDAP.phpcalled the method with a simple string, resulting in an exception and preventing folders shared with dynamic groups from working. This trivial change fixes the usage in Group_LDAP.Fixes #25163