-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix l10n #26287
Fix l10n #26287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whohoo
/backport to stable21 |
/backport to stable20 |
/backport to stable19 |
The backport to stable1 failed. Please do this backport manually. |
Errm the display name is overwritten here already: server/apps/dav/lib/CalDAV/Calendar.php Lines 66 to 68 in d9015a8
not enough? |
I guess the problem is activity is generated not using the users language but any so when the email is sent its en/default? |
@nickvergessen The problem with the birthday calendar is also this: #47330. |
Yeah but the change here is useless, as the value is always overwritten by the code I pointed out. |
I don't know if it's useless, but adding l10n to the text string fixes the display of the correct contact birthday calendar name in activities. See for yourself:
Perhaps the code needs to be changed, but this is left to the developers 😉. |
Issue: #26286