Separate Email Logo #26871

brueckner · 2021-05-04T14:16:07Z

This PR adds the ability to upload a separate logo for notification emails.

I basically copied most of the funtionality from the 'logo' upload field and added a fallback check in apps/theming/lib/ThemingDefaults.php. If no email logo is provided, the default logo will be used and if that's not present either, the default nextcloud logo will be used.

Related Issues:

Kind of related:

Logo not correctly displayed in share mails in Outlook #25463

Signed-off-by: Johannes Brückner <johannes@dotplex.com>

brueckner · 2021-05-11T14:05:37Z

Hi! Did anyone get a chance to take a look at it yet?

brueckner · 2021-05-25T11:13:21Z

I noticed that I didn't properly link to the issues I mentioned above. I fixed all of them and would still love to get some feedback. 🙄

skjnldsv · 2021-05-26T13:25:31Z

apps/theming/lib/ThemingDefaults.php

+			if (!$logoExists) {
+				try {
+					$logoKey = 'logo';
+					$logo = $this->config->getAppValue('theming', $logoKey . 'Mime', '');
+					$this->imageManager->getImage($logoKey, $useSvg);
+					$logoExists = true;
+				} catch (\Exception $e) {
+					$logoExists = false;
+				}
+			}


A bit more comments on the code please? :)
Maybe something like

Fallback to logo if there is no emailLogo registered

The new refactor based on @juliushaertl suggestion to extract it into a new getEmailLogo function greatly simplified the code, aligning it with the original getLogo function, so I think no additional comments are needed there. You're right though, I should've added some comments in this case. 👌

skjnldsv

Looks good, but don't hesitate to comment the code a bit further, it makes it easier to get the context at glance

juliusknorr

I'd generally be ok with adding a setting for this, but I'd pull in @jancborchardt here for some additional checking. 😉

juliusknorr · 2021-05-27T16:03:49Z

apps/theming/lib/ThemingDefaults.php

@@ -223,8 +223,10 @@ public function getColorPrimary() {
 	 * @param bool $useSvg Whether to point to the SVG image or a fallback
 	 * @return string
 	 */
-	public function getLogo($useSvg = true): string {
-		$logo = $this->config->getAppValue('theming', 'logoMime', '');
+	public function getLogo($useSvg = true, $emailLogo = false): string {


I'm a bit concerned with just adding another argument here so since this is a totally different logo file that can be uploaded I'd rather go with a separate method also in OCP\Defaults like getMailLogo.

That a very good point, thanks for bringing it up! I was actually thinking about that at first, but was afraid to get complains with regards to code duplication. However, having done the refactor now it feels much, much better and is totally worth a little duplication imho. Especially with regards to your other comment about the SVG - the new getEmailLogo doesn't have to be concerned with SVGs now. I'm just not sure how to restrict the email logo upload field to certain mime-types... 🤔 Any idea?

juliusknorr · 2021-05-27T16:06:31Z

apps/theming/lib/ImageManager.php

@@ -86,6 +86,7 @@ public function getImageUrl(string $key, bool $useSvg = true): string {

 		switch ($key) {
 			case 'logo':
+			case 'emailLogo':


Since svg is causing issues with email it would make sense to not allow to upload it then for an email logo:

https://github.com/nextcloud/server/pull/26871/files#diff-b9d526f6249d406c08009d9de5802b5637194bb66ec759df798dd397f9a422beR222-R225

Yep, you're absolutely right! The refactored version (see my other comment below) has no support for an SVG version.

jancborchardt · 2021-05-27T17:05:49Z

I'd generally be ok with adding a setting for this, but I'd pull in @jancborchardt here for some additional checking. 😉

@brueckner @juliushaertl is it not possible to fix the SVG-to-PNG generation?

As usual having a setting means that every single person has to set this, whereas if we would fix the generator, that'd be a whole lot of work saved for our end users.

… getEmailLogo method

brueckner · 2021-05-31T08:30:42Z

I'd generally be ok with adding a setting for this, but I'd pull in @jancborchardt here for some additional checking. 😉

@brueckner @juliushaertl is it not possible to fix the SVG-to-PNG generation?

As usual having a setting means that every single person has to set this, whereas if we would fix the generator, that'd be a whole lot of work saved for our end users.

It's not (only) about the blurry appearance of the logo, as some users have described in other issues. It's much more about that fact that you might want to have a completly different logo for your emails that suits the styling of the mails sent out by Nextcloud. The idea is to use the regular logo by default, so people don't have to use the setting at all, but this is part of a theming app that is supposed to offer customization, so offering some additional customization options won't hurt anyone I suppose. ;)

Sidenote: the current (refactored) verison does not fall back to the regular site logo (yet). I wanted to wait for some feedback on it before going the extra mile.

szaimen · 2021-06-23T14:47:48Z

@jancborchardt so how to proceed with this then?

szaimen · 2021-09-13T12:51:24Z

/rebase

juliusknorr · 2021-09-13T14:53:23Z

Having different logos might also be interesting here in cases where the small rendering of the email logo does not work well with the one that is supposed at the login page. The header logo can already be set separately but the one on used the login page might be considered for larger use and have detail that don't work well on the small size of the mail.

skjnldsv · 2021-10-22T09:54:34Z

What's the status here?

juliusknorr · 2021-10-22T13:23:29Z

Needs some decision if we want this in with an extra setting.

franciscomfcmaia · 2021-10-23T15:22:29Z

Needs some decision if we want this in with an extra setting.

but it seems like there isn't a solution for email logos using an SVG custom logo?

the SVG conversion is broken especially in snap (I respect the safety concerns regarding imagick)

M3taKn1ght · 2022-06-28T10:57:59Z

What is the current Status?

skjnldsv · 2024-02-27T17:42:45Z

As this sounds like a nice feature, the requests for this are quite low. Currently there a no plans to implement such a feature. Thus I will close this ticket for now.

Thanks for the interest in Nextcloud and the effort put into this! 🙇

Add a new email logo upload field in the theme settings

f6edb03

Signed-off-by: Johannes Brückner <johannes@dotplex.com>

szaimen added the 3. to review Waiting for reviews label May 11, 2021

szaimen requested review from juliusknorr, rullzer and ChristophWurst May 11, 2021 14:23

ChristophWurst requested review from skjnldsv, julien-nc, artonge and ArtificialOwl and removed request for ChristophWurst May 18, 2021 06:49

szaimen mentioned this pull request May 26, 2021

Theming app does not allow header logo to be resized #15955

Closed

skjnldsv reviewed May 26, 2021

View reviewed changes

szaimen mentioned this pull request May 27, 2021

Generated PNG logo images in in activity emails are blurry #11162

Closed

juliusknorr requested changes May 27, 2021

View reviewed changes

brueckner added 2 commits May 31, 2021 09:56

Revert changes to getLogo method prior to moving the code to separate…

5d98dac

… getEmailLogo method

Implement extracted getEmailLogo method

317dd23

szaimen added this to the Nextcloud 23 milestone Jun 23, 2021

skjnldsv mentioned this pull request Oct 13, 2021

23.0.0 beta 1 #29202

Merged

skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 22, 2021

This comment has been minimized.

Sign in to view

skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 30, 2021

kbzowski mentioned this pull request Feb 25, 2022

SVG logo URL embedded in emails return SVG content, despite useSvg=0 #13895

Closed

skjnldsv mentioned this pull request Mar 24, 2022

24.0.0 beta 1 #31693

Merged

blizzz mentioned this pull request Mar 31, 2022

24.0.0 beta 2 #31769

Merged

This was referenced Apr 7, 2022

24.0.0 beta 3 #31871

Merged

24.0.0 RC1 #31962

Merged

blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022

This was referenced Aug 12, 2022

25.0.0 beta 1 #33505

Merged

25.0.0 beta 2 #33592

Merged

This was referenced Aug 24, 2022

25.0.0 beta 3 #33674

Merged

25.0.0 beta 4 #33762

Merged

This was referenced Sep 6, 2022

25.0.0 beta 5 #33913

Merged

25.0.0 beta 6 #34002

Merged

skjnldsv mentioned this pull request Sep 15, 2022

25.0.0 beta 7 #34095

Merged

This was referenced Sep 20, 2022

25.0.0 beta 8 #34164

Closed

25.0.0 RC 1 #34185

Merged

blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022

ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 2. developing Work in progress labels Oct 17, 2022

ChristophWurst removed this from the Nextcloud 26 milestone Oct 17, 2022

skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 21, 2024

skjnldsv closed this Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate Email Logo #26871

Separate Email Logo #26871

brueckner commented May 4, 2021 •

edited

Loading

brueckner commented May 11, 2021

brueckner commented May 25, 2021

skjnldsv May 26, 2021

brueckner May 31, 2021

skjnldsv left a comment

juliusknorr left a comment

juliusknorr May 27, 2021

brueckner May 31, 2021

juliusknorr May 27, 2021

brueckner May 31, 2021

jancborchardt commented May 27, 2021

brueckner commented May 31, 2021 •

edited

Loading

szaimen commented Jun 23, 2021

szaimen commented Sep 13, 2021

juliusknorr commented Sep 13, 2021

skjnldsv commented Oct 22, 2021

juliusknorr commented Oct 22, 2021

franciscomfcmaia commented Oct 23, 2021

This comment has been minimized.

M3taKn1ght commented Jun 28, 2022

skjnldsv commented Feb 27, 2024

Separate Email Logo #26871

Separate Email Logo #26871

Conversation

brueckner commented May 4, 2021 • edited Loading

Related Issues:

Kind of related:

brueckner commented May 11, 2021

brueckner commented May 25, 2021

skjnldsv May 26, 2021

Choose a reason for hiding this comment

brueckner May 31, 2021

Choose a reason for hiding this comment

skjnldsv left a comment

Choose a reason for hiding this comment

juliusknorr left a comment

Choose a reason for hiding this comment

juliusknorr May 27, 2021

Choose a reason for hiding this comment

brueckner May 31, 2021

Choose a reason for hiding this comment

juliusknorr May 27, 2021

Choose a reason for hiding this comment

brueckner May 31, 2021

Choose a reason for hiding this comment

jancborchardt commented May 27, 2021

brueckner commented May 31, 2021 • edited Loading

szaimen commented Jun 23, 2021

szaimen commented Sep 13, 2021

juliusknorr commented Sep 13, 2021

skjnldsv commented Oct 22, 2021

juliusknorr commented Oct 22, 2021

franciscomfcmaia commented Oct 23, 2021

This comment has been minimized.

M3taKn1ght commented Jun 28, 2022

skjnldsv commented Feb 27, 2024

brueckner commented May 4, 2021 •

edited

Loading

brueckner commented May 31, 2021 •

edited

Loading