-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nmc 434-changed the process of sharing #28832
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSI-yogeshshejwadkar
force-pushed
the
NMC-434
branch
from
September 14, 2021 14:14
b044fec
to
9e5264f
Compare
skjnldsv
added
2. developing
Work in progress
feature: sharing
feature: file sidebar
Related to the file sidebar component
labels
Sep 15, 2021
Hi @TSI-yogeshshejwadkar could you add screenshots for easier design review? Thanks a lot! :) |
Updated :) |
TSI-yogeshshejwadkar
force-pushed
the
NMC-434
branch
2 times, most recently
from
September 23, 2021 06:33
8554b34
to
925b621
Compare
@juliushaertl @skjnldsv can you provide to review feedback here? Also if merged it should get backported to 22+ cc @schiessle as discussed |
Also @jancborchardt for feedback on the updated UI. |
TSI-yogeshshejwadkar
force-pushed
the
NMC-434
branch
from
October 4, 2021 12:19
925b621
to
bb9315e
Compare
kesselb
changed the title
Nmc 434 - changed the process of sharing
Nmc 434-changed the process of sharing
Oct 26, 2021
…al sharee Signed-off-by: Yogesh Shejwadkar <yogesh.shejwadkar@t-systems.com>
Signed-off-by: Yogesh Shejwadkar <yogesh.shejwadkar@t-systems.com>
Signed-off-by: Yogesh Shejwadkar <yogesh.shejwadkar@t-systems.com>
Signed-off-by: Yogesh Shejwadkar <yogesh.shejwadkar@t-systems.com>
Signed-off-by: Yogesh Shejwadkar <yogesh.shejwadkar@t-systems.com>
Signed-off-by: Yogesh Shejwadkar <yogesh.shejwadkar@t-systems.com>
Signed-off-by: Yogesh Shejwadkar <yogesh.shejwadkar@t-systems.com>
Merged
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Superseeded by #26691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
feature: file sidebar
Related to the file sidebar component
feature: sharing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1:
Folders
Internal Share:
we removed the checkboxes "Allow editing", "Allow creating" and "Allow deleting"
we added a radio button group containing the options: "Read only" (Nur Lesen), "Allow upload and editing" (Hochladen & Bearbeiten)
External Share: no changes
Link Share: no changes
Files
Internal Share:
we removed the checkbox "Allow editing"
we added a radio button group containing the options: "Read only" (Nur lesen), "Editing" (Bearbeiten)
External Share:
we removed the checkbox "Allow editing"
we added a radio button group containing the options: "Read only" (Nur lesen), "Editing" (Bearbeiten)
Link Share:
we removed the checkbox "Allow editing"
we added a radio button group containing the options: "Read only" (Nur lesen), "Editing" (Bearbeiten)
Step 2:
We added a new dropdown button under the display of the email-address or account name of the recipient
For folders
Internal user - Ready only and Allow upload and editing
External user - Read only, allow upload and editing, file drop
Share link - Read only, allow upload and editing, file drop
For files
Internal user - Read only, editing
External user - Read only ,editing
Share link - Read only ,editing
Ignored hasStatus which is having message and icon below user name or email address. We are removing this functionality in sharing 4. Also Nextcloud will change something with that function after we added this new button as discussed with Jens.
Also keeping the existing options in hamburger menu, as we will remove those in sharing 3.
In Step 3:
we want to change the conplete process of sharing. Let's explain it also in small steps:
-> We don't want to send directly an Email for internal and external shares to the recipient after we entered the Email address
->instead of sending directly the Email, the user will now get lead to a full right menu view with the sharing and premission options first
-> after the first page of sharing and permission options, there will be a second full right menu view for entering a message to the Email (note to recipient option of Nextcloud)
Please ignore as well the shown permission options in the full right menu views. Please concentrate to extract existing sharing options of the different sharing systems (internal, external & link shares). So we are extracting all existing options (except "note to recipeient") to build the first full right menu view and we use the existing "note to recipient" function to create a second full right menu view. We combine them to the flow, which is drafted within the attached screens.
Acceptance Criteria:
if the user enters an Email-address and confirms it by pressing 'enter', the autofill function of Nextcloud will provide suggestions (it is already like this in Nextcloud and we keep that)
when the user now tabs on a provided Email-Address, we are not anymore sending directly an Email to the repient
we are instead leading the user to a first full right menu view with the permission and sharing options containing:
Radio button group with permission options (Read only, Upload and editing, Filedrop if it is a folder)
we group up under a small headline called "Advanced settings" (ger: "Erweiterte Einstellungen") all the rest of the sharing options e.g. password, expiration date, hide download, and so on) but not the "note to recipient" option!
on this full right menu view ** the user can "Cancel" or "Next" by having two buttons
if the user continues by clicking on "Next" he will get lead to another full right menu view ** with the last sharing option of "note to recipient" of Nextloud. Here the user can enter text.
on this view the user can "Cancel" or "Send share" by having two buttons
we removing all options from the exisitng "..."-menu except "unshare"
hide download should disable on file drop permission
After the process
clicking on the "..."-menu will slide in a button menu (like on the big "add" button n Nextcloud) with the following options:**
"Open in..." (ger: "Öffnen mit...") -> will open the Android share screen for sharing with other applications
we added"Advanced permissions" (ger: "Erweiterte Berechtigungen")
"Advanced permissions" will lead to the first new full right menu view ** with all the permission option (except note to recipient) with 2 Button: "Cancel" (ger: "Abbrechen") and "Confirm" (ger: "Übernehmen")
we added to the existing "..."-menu "Send new email" (ger: "Neue Email versenden")
"Send new email" will lead to the second new full right menu view ** with the text field to enter a message; we added two buttons: "Cancel" (ger: "Abbrechen") and "Send email" (ger: "Email senden")
"Unshare" (ger: "Freigabe beenden") will remove the share
we removed all the other remaining options by hiding them
clicking on the new permission button ot of Sharing #2 will lead to standard Nextccloud dialog box with the radio button options (read only, can edit, file drop if it is a folder)