Add L10n factory method for generic language heuristics #29015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
enhancement
2. developing
nickvergessen
approved these changes
Oct 1, 2021
The existing `findLanguage` method tries its best to find the best language for the current users. For some tasks we don't want this but rather determine the most generic language for *another* user, e.g. when the current user trigger an email notifiaction to someone else. In this case the current user's language is a bad guess in many multi-language environments. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/l10n-factory-find-generic-language
branch
from
2d8793b to
5b727fc
Compare
ChristophWurst
added
3. to review
1 task
skjnldsv
approved these changes
Oct 13, 2021
skjnldsv
added
4. to release
ChristophWurst
deleted the
enhancement/l10n-factory-find-generic-language
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
findLanguagemethod tries its best to find the bestlanguage for the current users. For some tasks we don't want this but
rather determine the most generic language for another user, e.g. when
the current user trigger an email notification to someone else. In this
case the current user's language is a bad guess in many multi-language
environments.
Ref #28665 (comment), we'll need this new method to finally fix calendar invites that are sent with the wrong language.