Allow scripts prioritization based on other apps

[skjnldsv]

1. This allow to set after which app some scripts should be loaded.
2. This creates a bit more flexibility and control over script dependencies.
3. This deprecates the current old addScript legacy behaviour

Example given:

• files_pdfviewer depends on viewer (Comply to new addScript API files_pdfviewer#522)
• viewer depends on files (Comply to new addScript API viewer#1081)
• files depends on core

Before we had to rely on luck, then use a watcher to catch any initialization that came after Viewer got updated.
Now, I can only check on viewer initialization and that's it.

Rules:

1. Core always gets prioritized
2. You can specify only ONE dependency
3. If the dependency does NOT exists, it will fallback to the php process order (default current)

[ChristophWurst]

This is still a very fragile system, isn't it? It only works because we include the scripts in an sync fashion, therefore causing a slow page load. Once we do the recommended async loading the order script tags won't matter anymore and the same problems show.

What part of viewer is it that other apps have to await before they can run? Does viewer do anything async in its initialization?

[skjnldsv]

This is still a very fragile system, isn't it? It only works because we include the scripts in an sync fashion, therefore causing a slow page load. Once we do the recommended async loading the order script tags won't matter anymore and the same problems show.

What part of viewer is it that other apps have to await before they can run? Does viewer do anything async in its initialization?

Yes and no. On the frontend, viewer can then wait for the DOMContentLoaded event.
The main issues is that there is only two steps, initializing and initialized. So if we load everything in a proper order (Core, Files, Viewer, PDFViewer), then Viewer can to its own init after the page is loaded, solving any API order. You can check the other PRs, this seems to works quite well.

[skjnldsv]

Once we do the recommended async loading the order script tags won't matter anymore and the same problems show

Well, this is an entirely different issue to address. We'd have to rebuild our entire way to think (how we design APIS, how we register namespaces, etc etc), maybe it's a good first step?
I'm open to suggestions 🤔

EDIT: @ChristophWurst So, we apparently already defer all scripts. And it works with this change. So I guess it's all good! :)

[skjnldsv]

Tests fixed

[ChristophWurst]

I was more thinking of moving the script tags from head to body but 👍

[nickvergessen]

🐘

[Pytal]

Was commiting lib/composer/bamarni/composer-bin-plugin intentional? this was auto-added for me before and I had to remove it manually 🤷‍♂️

[ChristophWurst]

It should not be in git. Run composer i --no-dev

[skjnldsv]

It should not be in git. Run composer i --no-dev

Yes 😢
I hate this so much ^^'

[ChristophWurst]

Sad CI noise

[skjnldsv]

https://drone.nextcloud.com/nextcloud/server/12529/